dashboard / erock/pico / chore(feeds): better error handling for invalid feed files #41 rss

accepted · opened on 2025-01-10T15:10:28Z by erock
Help
checkout latest patchset: 
ssh pr.pico.sh print pr-41 | git am -3
checkout any patchset in a patch request: 
ssh pr.pico.sh print ps-X | git am -3
add changes to patch request: 
git format-patch main --stdout | ssh pr.pico.sh pr add 41
add review to patch request: 
git format-patch main --stdout | ssh pr.pico.sh pr add --review 41
accept PR: 
ssh pr.pico.sh pr accept 41
close PR: 
ssh pr.pico.sh pr close 41

Logs

erock created pr with ps-87 on 2025-01-10T15:10:28Z
erock added ps-88 on 2025-01-10T15:14:05Z
erock changed status on 2025-01-18T20:21:19Z {"status":"accepted"}

Patchsets

ps-87 by erock on 2025-01-10T15:10:28Z
Range Diff ↕ rd-88
1: 5d5b1f5 ! 1: a6f10fc chore(feeds): better error handling for invalid feed files
ps-88 by erock on 2025-01-10T15:14:05Z

Range-diff rd-88

title
chore(feeds): better error handling for invalid feed files
description
Patch changed
old #1
5d5b1f5
new #1
a6f10fc
Back to top
1: 5d5b1f5 ! 1: a6f10fc chore(feeds): better error handling for invalid feed files
message changed
- 
+ When a user uploads an invalid feed file we do not have any mechanism to
notify that user.  Further will continue to attempt to run the file
through our rss-to-email cron.

This commit makes it so we perform validation on the feed files as they
are uploaded and refused to save files that we know will eventually
fail.

Further, we don't want to continuously try files that we know will not
succeed so we are pushing those known issues into our retry-then-delete
mechanism inside our cron.