borogove
created pr with
borogove/muc-create.1
added borogove/muc-create.2
1: 7eacfb3 < -: ------- Initial channel creation
2: 4b5a982 ! 1: d85d8d1 review
3: 8c9556b < -: ------- Support intant room creation
4: 941aad7 < -: ------- Add tests
added borogove/muc-create.3
-: ------- > 1: 0aa766b Initial channel creation
1: d85d8d1 ! 2: a7f33d5 After config form is submitted, creation is complete
-: ------- > 3: e6042b0 Support intant room creation
-: ------- > 4: 366bac7 Add tests
-: ------- > 5: fece298 review
-: ------- > 6: 322b2bd Review replies
added borogove/muc-create.4
1: 0aa766b = 1: 0aa766b Initial channel creation
2: a7f33d5 = 2: a7f33d5 After config form is submitted, creation is complete
3: e6042b0 = 3: e6042b0 Support intant room creation
4: 366bac7 ! 4: 0da1c7e Add tests
5: fece298 = 5: 86bad8e review
6: 322b2bd = 6: 997cf5a Review replies
commented
lgtm!
cmds
checkout latest patchset:
ssh pr.pico.sh pull borogove:muc-create | git am -3checkout specific patchset revision:
ssh pr.pico.sh pull borogove:muc-create [rev] | git am -3add changes to patch request:
git format-patch main --stdout | ssh pr.pico.sh borogove:muc-createadd comment to patch request:
ssh pr.pico.sh comment borogove:muc-create "lgtm!"
Patchset
borogove/muc-create.4
Initial channel creation
Stephen Paul Weber
After config form is submitted, creation is complete
2026-10-28T19:34:47ZStephen Paul Weber
Support intant room creation
2026-10-28T19:56:35ZStephen Paul Weber
Add tests
2026-10-28T20:42:50ZStephen Paul Weber
review
2026-10-28T20:49:11ZEric Roberts
→ Review replies
2026-10-30T12:26:06ZStephen Paul Weber
2026-11-03T03:39:25Z
Review replies
Stephen Paul Weber
2026-11-03T03:39:25ZSemantic diff summary
0 added,
0 modified,
0 signature changed,
0 removed
across 0 analyzed files
(1 file skipped: unsupported file type)
+1
-0
borogove/Chat.hx
#
| ... | ... | @@ -1641,6 +1641,7 @@ class Channel extends Chat { | |
| 1641 | 1641 | } | |
| 1642 | 1642 | ); | |
| 1643 | 1643 | // eric: does syncing actually cause a problem or is this just an optimization? | |
| 1644 | + | // singpolyma: just an optimization really, doing the sync would get either an error or empty at this point | |
| 1644 | 1645 | if (uiState != Creating) persistence.syncPoint(client.accountId(), chatId).then((point) -> doSync(point)); | |
| 1645 | 1646 | ||
| 1646 | 1647 | return null; |