borogove

Use to for chatId if not in recipients rss

created pr with borogove/multi-dm.1 on 2026-11-09T19:47:55Z · by 9e834e0d

added borogove/multi-dm.2 on 2026-11-10T19:08:22Z · by 9e834e0d


                      1:  0ef2769 = 1:  41e89c8 Use to for chatId if not in recipients


                      2:  90e5a6a = 2:  c323e3d clone should clone attributes


                      3:  d86ea28 = 3:  a1199ae Actually send to all recipients


                      4:  1c1061f ! 4:  94bf87d Never add self as counterpart


                      5:  9c8aa41 = 5:  32b9fad Extended addressing for sent messages specifies all recipients


                      6:  2da9124 = 6:  ce4d9e1 Always add all recipients to outbound message


                      7:  e7db006 = 7:  350343e Use a shared helper for adding extended addressing


                      8:  4530ece = 8:  40f662a Add startMultiChat to create multiDMs


                      9:  6810ba9 = 9:  8043c53 Never include ourselves in incoming chat ids


                      -:  ------- > 10:  68e7246 Cannot MAM or bookmark a multiDM

cmds

checkout latest patchset:

ssh pr.pico.sh pull borogove:multi-dm | git am -3

checkout specific patchset revision:

ssh pr.pico.sh pull borogove:multi-dm [rev] | git am -3

add changes to patch request:

git format-patch main --stdout | ssh pr.pico.sh borogove:multi-dm

add comment to patch request:

ssh pr.pico.sh comment borogove:multi-dm "lgtm!"

Patchset `borogove/multi-dm.2` on 2026-11-10T19:08:22Z · commit 94bf87d

Use to for chatId if not in recipients

Stephen Paul Weber 2026-11-08T19:15:14Z

clone should clone attributes

Stephen Paul Weber 2026-11-09T16:18:06Z

Actually send to all recipients

Stephen Paul Weber 2026-11-09T16:24:50Z

→ Never add self as counterpart

Stephen Paul Weber 2026-11-08T19:20:04Z

Extended addressing for sent messages specifies all recipients

Stephen Paul Weber 2026-11-08T19:20:46Z

Always add all recipients to outbound message

Stephen Paul Weber 2026-11-08T19:21:50Z

Use a shared helper for adding extended addressing

Stephen Paul Weber 2026-11-08T19:32:30Z

Add startMultiChat to create multiDMs

Stephen Paul Weber 2026-11-08T21:01:35Z

Never include ourselves in incoming chat ids

Stephen Paul Weber 2026-11-09T19:40:59Z

Cannot MAM or bookmark a multiDM

Stephen Paul Weber 2026-11-10T17:34:01Z

Never add self as counterpart

Stephen Paul Weber 2026-11-08T19:20:04Z

Semantic diff summary

0 added, 0 modified, 0 signature changed, 0 removed across 0 analyzed files (2 files skipped: unsupported file type)

+2 -1 borogove/Chat.hx #

......@@ -1191,7 +1191,8 @@ class DirectChat extends Chat {
		// If last message at load time is a sent message, this may not include everyone
		if (_fullCounterparts.length < 2 && (message?.recipients?.length ?? 0) > 1) {
			_fullCounterparts = message.recipients.map(r -> r.asBare().asString()).filter(id -> id != client.accountId());
			if (!_fullCounterparts.contains(message.senderId)) _fullCounterparts.push(message.senderId);
			final senderId = JID.parse(message.senderId).asBare().asString();
			if (senderId != client.accountId() && !_fullCounterparts.contains(senderId)) _fullCounterparts.push(senderId);
		}
		return super.setLastMessage(message);
	}

+24 -0 test/TestChat.hx #

......@@ -1271,6 +1271,30 @@ class TestChat extends utest.Test {
		chat.sendMessage(builder, borogove.Chat.OutgoingE2EEPreference.NoE2EE);
	}

	public function testCompatMultiDMParticipantsRecoveredFromOutgoingLastMessage(async: Async) {
		final persistence = new Dummy();
		final client = new Client("me@example.com", persistence);
		final chat = new borogove.Chat.DirectChat(client, client.stream, persistence, "multi@example.com");

		final builder = new ChatMessageBuilder();
		builder.localId = "out-1";
		builder.sortId = "a0";
		builder.direction = MessageSent;
		builder.from = JID.parse("me@example.com");
		builder.senderId = "me@example.com";
		builder.to = JID.parse("multi@example.com");
		builder.recipients = [JID.parse("bob@example.com"), JID.parse("carol@example.com")];
		builder.replyTo = [JID.parse("me@example.com")];

		chat.setLastMessage(builder.build()).then(_ -> {
			Assert.same(["bob@example.com", "carol@example.com"], chat._fullCounterparts);
			chat.members().then(members -> {
				final ids = members.map(m -> m.id);
				Assert.same(["bob@example.com", "carol@example.com", "me@example.com"], ids);
				async.done();
			});
		});
	}
}

@:access(borogove)

...	...		@@ -1191,7 +1191,8 @@ class DirectChat extends Chat {
1191	1191		// If last message at load time is a sent message, this may not include everyone
1192	1192		if (_fullCounterparts.length < 2 && (message?.recipients?.length ?? 0) > 1) {
1193	1193		_fullCounterparts = message.recipients.map(r -> r.asBare().asString()).filter(id -> id != client.accountId());
1194		-	if (!_fullCounterparts.contains(message.senderId)) _fullCounterparts.push(message.senderId);
	1194	+	final senderId = JID.parse(message.senderId).asBare().asString();
	1195	+	if (senderId != client.accountId() && !_fullCounterparts.contains(senderId)) _fullCounterparts.push(senderId);
1195	1196		}
1196	1197		return super.setLastMessage(message);
1197	1198		}

...	...		@@ -1271,6 +1271,30 @@ class TestChat extends utest.Test {
1271	1271		chat.sendMessage(builder, borogove.Chat.OutgoingE2EEPreference.NoE2EE);
1272	1272		}
1273	1273
	1274	+	public function testCompatMultiDMParticipantsRecoveredFromOutgoingLastMessage(async: Async) {
	1275	+	final persistence = new Dummy();
	1276	+	final client = new Client("me@example.com", persistence);
	1277	+	final chat = new borogove.Chat.DirectChat(client, client.stream, persistence, "multi@example.com");
	1278	+
	1279	+	final builder = new ChatMessageBuilder();
	1280	+	builder.localId = "out-1";
	1281	+	builder.sortId = "a0";
	1282	+	builder.direction = MessageSent;
	1283	+	builder.from = JID.parse("me@example.com");
	1284	+	builder.senderId = "me@example.com";
	1285	+	builder.to = JID.parse("multi@example.com");
	1286	+	builder.recipients = [JID.parse("bob@example.com"), JID.parse("carol@example.com")];
	1287	+	builder.replyTo = [JID.parse("me@example.com")];
	1288	+
	1289	+	chat.setLastMessage(builder.build()).then(_ -> {
	1290	+	Assert.same(["bob@example.com", "carol@example.com"], chat._fullCounterparts);
	1291	+	chat.members().then(members -> {
	1292	+	final ids = members.map(m -> m.id);
	1293	+	Assert.same(["bob@example.com", "carol@example.com", "me@example.com"], ids);
	1294	+	async.done();
	1295	+	});
	1296	+	});
	1297	+	}
1274	1298		}
1275	1299
1276	1300		@:access(borogove)

borogove

Patchset borogove/multi-dm.2 on 2026-11-10T19:08:22Z · commit 94bf87d

Patchset `borogove/multi-dm.2` on 2026-11-10T19:08:22Z · commit 94bf87d