hxcpp

SSL read/write needs to return wouldblock if partial read rss

created pr with hxcpp/ssl-short-read.1 on 2026-10-27T21:26:44Z · by d7025af3

added hxcpp/ssl-short-read.2 on 2026-10-27T21:29:42Z · by d7025af3


                      1:  d70d1ca < -:  ------- SSL read/write needs to return wouldblock if partial read


                      -:  ------- > 1:  dd64130 SSL read/write needs to return wouldblock if partial read


                      2:  af61d88 = 2:  d3fe10a Throw exceptions for more error codes


                      3:  124b85a = 3:  6f33bf1 Retry handshake on would block


                      4:  e8e22fe = 4:  5a504b4 Include whole erorr message in exception

cmds

checkout latest patchset:

ssh pr.pico.sh pull hxcpp:ssl-short-read | git am -3

checkout specific patchset revision:

ssh pr.pico.sh pull hxcpp:ssl-short-read [rev] | git am -3

add changes to patch request:

git format-patch main --stdout | ssh pr.pico.sh hxcpp:ssl-short-read

add comment to patch request:

ssh pr.pico.sh comment hxcpp:ssl-short-read "lgtm!"

Patchset `hxcpp/ssl-short-read.1` on 2026-10-27T21:26:44Z · commit 124b85a

SSL read/write needs to return wouldblock if partial read

Stephen Paul Weber 2026-10-27T21:17:55Z

Throw exceptions for more error codes

Stephen Paul Weber 2026-10-27T21:18:19Z

→ Retry handshake on would block

Stephen Paul Weber 2026-10-27T21:18:51Z

Include whole erorr message in exception

Stephen Paul Weber 2026-10-27T21:19:11Z

Retry handshake on would block

Stephen Paul Weber 2026-10-27T21:18:51Z

otherwise haxe just throws Block, no good

Semantic diff summary

0 added, 0 modified, 0 signature changed, 0 removed across 0 analyzed files (1 file skipped: unsupported file type)

+1 -1 Sources/c_borogove/src/hx/libs/ssl/SSL.cpp #

......@@ -149,7 +149,7 @@ void _hx_ssl_set_hostname(Dynamic hssl, String hostname) {
void _hx_ssl_handshake(Dynamic hssl) {
	sslctx* ctx = val_ssl(hssl);
	OSStatus s = SSLHandshake(ctx->sslCtx);
	if (s == errSSLWouldBlock) hx::Throw(HX_CSTRING("Blocking"));
	if (s == errSSLWouldBlock) return _hx_ssl_handshake(hssl);
	if (s != noErr) hx::Throw(HX_CSTRING("SSL handshake error"));
}

...	...		@@ -149,7 +149,7 @@ void _hx_ssl_set_hostname(Dynamic hssl, String hostname) {
149	149		void _hx_ssl_handshake(Dynamic hssl) {
150	150		sslctx* ctx = val_ssl(hssl);
151	151		OSStatus s = SSLHandshake(ctx->sslCtx);
152		-	if (s == errSSLWouldBlock) hx::Throw(HX_CSTRING("Blocking"));
	152	+	if (s == errSSLWouldBlock) return _hx_ssl_handshake(hssl);
153	153		if (s != noErr) hx::Throw(HX_CSTRING("SSL handshake error"));
154	154		}
155	155

hxcpp

Patchset hxcpp/ssl-short-read.1 on 2026-10-27T21:26:44Z · commit 124b85a

Patchset `hxcpp/ssl-short-read.1` on 2026-10-27T21:26:44Z · commit 124b85a