pico

created pr with pico/62.1 on 2025-04-08T15:27:23Z · by c8ef7d19

cmds

checkout latest patchset:

ssh pr.pico.sh pull pico:62 | git am -3

checkout specific patchset revision:

ssh pr.pico.sh pull pico:62 [rev] | git am -3

add changes to patch request:

git format-patch main --stdout | ssh pr.pico.sh pico:62

add comment to patch request:

ssh pr.pico.sh comment pico:62 "lgtm!"

Patchset `pico/62.1` on 2025-04-08T15:27:23Z · commit 21ef055

→ chore: lru cache for txt lookup

Eric Bower 2025-04-08T15:27:02Z

chore: lru cache for txt lookup

Eric Bower 2025-04-08T15:27:02Z

Semantic diff summary

0 added, 2 modified, 0 signature changed, 0 removed across 1 analyzed file

pkg/shared/router.go

chunk lines 10-17 modified
function_declaration GetCustomDomain modified

+12 -1 pkg/shared/router.go #

......@@ -10,6 +10,8 @@ import (
	"regexp"
	"strings"

	"github.com/hashicorp/golang-lru/v2/expirable"
	"github.com/picosh/pico/pkg/cache"
	"github.com/picosh/pico/pkg/db"
	"github.com/picosh/pico/pkg/pssh"
	"github.com/picosh/pico/pkg/shared/storage"

......@@ -211,15 +213,24 @@ func GetSubdomain(r *http.Request) string {
	return r.Context().Value(CtxSubdomainKey{}).(string)
}

var txtCache = expirable.NewLRU[string, string](2048, nil, cache.CacheTimeout)

func GetCustomDomain(host string, space string) string {
	txt := fmt.Sprintf("_%s.%s", space, host)
	record, found := txtCache.Get(txt)
	if found {
		return record
	}

	records, err := net.LookupTXT(txt)
	if err != nil {
		return ""
	}

	for _, v := range records {
		return strings.TrimSpace(v)
		rec := strings.TrimSpace(v)
		txtCache.Add(txt, rec)
		return rec
	}

	return ""

...	...		@@ -211,15 +213,24 @@ func GetSubdomain(r *http.Request) string {
211	213		return r.Context().Value(CtxSubdomainKey{}).(string)
212	214		}
213	215
	216	+	var txtCache = expirable.NewLRU[string, string](2048, nil, cache.CacheTimeout)
	217	+
214	218		func GetCustomDomain(host string, space string) string {
215	219		txt := fmt.Sprintf("_%s.%s", space, host)
	220	+	record, found := txtCache.Get(txt)
	221	+	if found {
	222	+	return record
	223	+	}
	224	+
216	225		records, err := net.LookupTXT(txt)
217	226		if err != nil {
218	227		return ""
219	228		}
220	229
221	230		for _, v := range records {
222		-	return strings.TrimSpace(v)
	231	+	rec := strings.TrimSpace(v)
	232	+	txtCache.Add(txt, rec)
	233	+	return rec
223	234		}
224	235
225	236		return ""

...	...		@@ -10,6 +10,8 @@ import (
10	10		"regexp"
11	11		"strings"
12	12
	13	+	"github.com/hashicorp/golang-lru/v2/expirable"
	14	+	"github.com/picosh/pico/pkg/cache"
13	15		"github.com/picosh/pico/pkg/db"
14	16		"github.com/picosh/pico/pkg/pssh"
15	17		"github.com/picosh/pico/pkg/shared/storage"

pico

Patchset pico/62.1 on 2025-04-08T15:27:23Z · commit 21ef055

Patchset `pico/62.1` on 2025-04-08T15:27:23Z · commit 21ef055