dashboard / erock/git-pr / chore: remove dead code #1 rss

accepted · opened on 2024-07-18T18:03:12Z by erock
Help
checkout latest patchset:
ssh pr.pico.sh print pr-1 | git am -3
checkout any patchset in a patch request:
ssh pr.pico.sh print ps-X | git am -3
add changes to patch request:
git format-patch main --stdout | ssh pr.pico.sh pr add 1
add review to patch request:
git format-patch main --stdout | ssh pr.pico.sh pr add --review 1
accept PR:
ssh pr.pico.sh pr accept 1
close PR:
ssh pr.pico.sh pr close 1

Logs

erock created pr with ps-1 on 2024-07-18T18:03:12Z
jolheiser changed status on 2024-07-18T18:17:18Z {"status":"accepted"}

Patchsets

ps-1 by erock on 2024-07-18T18:03:12Z

Patchset ps-1

chore: remove dead code

Eric Bower
2024-07-18T18:02:40Z
util.go
+0 -111
Back to top

chore: remove dead code

util.go link
+0 -111
  1
  2
  3
  4
  5
  6
  7
  8
  9
 10
 11
 12
 13
 14
 15
 16
 17
 18
 19
 20
 21
 22
 23
 24
 25
 26
 27
 28
 29
 30
 31
 32
 33
 34
 35
 36
 37
 38
 39
 40
 41
 42
 43
 44
 45
 46
 47
 48
 49
 50
 51
 52
 53
 54
 55
 56
 57
 58
 59
 60
 61
 62
 63
 64
 65
 66
 67
 68
 69
 70
 71
 72
 73
 74
 75
 76
 77
 78
 79
 80
 81
 82
 83
 84
 85
 86
 87
 88
 89
 90
 91
 92
 93
 94
 95
 96
 97
 98
 99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
diff --git a/util.go b/util.go
index 5c6e41e..abb0a68 100644
--- a/util.go
+++ b/util.go
@@ -6,12 +6,10 @@ import (
 	"encoding/hex"
 	"fmt"
 	"io"
-	"log/slog"
 	"math/rand"
 	"regexp"
 	"strconv"
 	"strings"
-	"time"
 
 	"github.com/bluekeyes/go-gitdiff/gitdiff"
 	"github.com/charmbracelet/ssh"
@@ -211,112 +209,3 @@ func calcContentSha(diffFiles []*gitdiff.File, header *gitdiff.PatchHeader) stri
 	shaStr := hex.EncodeToString(sha[:])
 	return shaStr
 }
-
-func AuthorDateToTime(date string, logger *slog.Logger) time.Time {
-	// TODO: convert sql column to DATETIME
-	ds, err := time.Parse("2006-01-02T15:04:05Z", date)
-	if err != nil {
-		logger.Error(
-			"cannot parse author date for patch",
-			"datetime", date,
-			"err", err,
-		)
-		return time.Now()
-	}
-	return ds
-}
-
-/* func filterPatches(ranger *Ranger, patches []*Patch) []*Patch {
-	if ranger.Left == ranger.Right {
-		return []*Patch{patches[ranger.Left]}
-	}
-	return patches[ranger.Left:ranger.Right]
-}
-
-type Ranger struct {
-	Left  int
-	Right int
-}
-
-func parseRange(rnge string, sliceLen int) (*Ranger, error) {
-	items := strings.Split(rnge, ":")
-	left := 0
-	var err error
-	if items[0] != "" {
-		left, err = strconv.Atoi(items[0])
-		if err != nil {
-			return nil, fmt.Errorf("first value before `:` must provide number")
-		}
-	}
-
-	if left < 0 {
-		return nil, fmt.Errorf("first value must be >= 0")
-	}
-
-	if left >= sliceLen {
-		return nil, fmt.Errorf("first value must be less than number of patches")
-	}
-
-	if len(items) == 1 {
-		return &Ranger{
-			Left:  left,
-			Right: left,
-		}, nil
-	}
-
-	if items[1] == "" {
-		return &Ranger{Left: left, Right: sliceLen - 1}, nil
-	}
-
-	right, err := strconv.Atoi(items[1])
-	if err != nil {
-		return nil, fmt.Errorf("second value after `:` must provide number")
-	}
-
-	if left > right {
-		return nil, fmt.Errorf("second value must be greater than first value")
-	}
-
-	if right >= sliceLen {
-		return nil, fmt.Errorf("second value must be less than number of patches")
-	}
-
-	return &Ranger{
-		Left:  left,
-		Right: right,
-	}, nil
-} */
-
-/* func gitServiceCommands(sesh ssh.Session, be *Backend, cmd, repoName string) error {
-	name := utils.SanitizeRepo(repoName)
-	// git bare repositories should end in ".git"
-	// https://git-scm.com/docs/gitrepository-layout
-	repoID := be.RepoID(name)
-	reposDir := be.ReposDir()
-	err := git.EnsureWithin(reposDir, repoID)
-	if err != nil {
-		return err
-	}
-	repoPath := filepath.Join(reposDir, repoID)
-	serviceCmd := git.ServiceCommand{
-		Stdin:  sesh,
-		Stdout: sesh,
-		Stderr: sesh.Stderr(),
-		Dir:    repoPath,
-		Env:    sesh.Environ(),
-	}
-
-	if cmd == "git-receive-pack" {
-		err := git.ReceivePack(sesh.Context(), serviceCmd)
-		if err != nil {
-			return err
-		}
-	} else if cmd == "git-upload-pack" {
-		err := git.UploadPack(sesh.Context(), serviceCmd)
-		if err != nil {
-			return err
-		}
-	}
-
-	return nil
-} */