Logs
erock
created pr with ps-1
on jolheiser
changed status
on {"status":"accepted"}
Patchsets
Diff ↕
chore: remove dead code
Eric Bower <me@erock.io>
util.go | 111 -------------------------------------------------------- 1 file changed, 111 deletions(-)
1From 3a945b121a7e9a4695bee935fb1785c3d9108d9c Mon Sep 17 00:00:00 2001
2From: Eric Bower <me@erock.io>
3Date: Thu, 18 Jul 2024 14:02:40 -0400
4Subject: [PATCH] chore: remove dead code
5
6---
7 util.go | 111 --------------------------------------------------------
8 1 file changed, 111 deletions(-)
9
10diff --git a/util.go b/util.go
11index 5c6e41e..abb0a68 100644
12--- a/util.go
13+++ b/util.go
14@@ -6,12 +6,10 @@ import (
15 "encoding/hex"
16 "fmt"
17 "io"
18- "log/slog"
19 "math/rand"
20 "regexp"
21 "strconv"
22 "strings"
23- "time"
24
25 "github.com/bluekeyes/go-gitdiff/gitdiff"
26 "github.com/charmbracelet/ssh"
27@@ -211,112 +209,3 @@ func calcContentSha(diffFiles []*gitdiff.File, header *gitdiff.PatchHeader) stri
28 shaStr := hex.EncodeToString(sha[:])
29 return shaStr
30 }
31-
32-func AuthorDateToTime(date string, logger *slog.Logger) time.Time {
33- // TODO: convert sql column to DATETIME
34- ds, err := time.Parse("2006-01-02T15:04:05Z", date)
35- if err != nil {
36- logger.Error(
37- "cannot parse author date for patch",
38- "datetime", date,
39- "err", err,
40- )
41- return time.Now()
42- }
43- return ds
44-}
45-
46-/* func filterPatches(ranger *Ranger, patches []*Patch) []*Patch {
47- if ranger.Left == ranger.Right {
48- return []*Patch{patches[ranger.Left]}
49- }
50- return patches[ranger.Left:ranger.Right]
51-}
52-
53-type Ranger struct {
54- Left int
55- Right int
56-}
57-
58-func parseRange(rnge string, sliceLen int) (*Ranger, error) {
59- items := strings.Split(rnge, ":")
60- left := 0
61- var err error
62- if items[0] != "" {
63- left, err = strconv.Atoi(items[0])
64- if err != nil {
65- return nil, fmt.Errorf("first value before `:` must provide number")
66- }
67- }
68-
69- if left < 0 {
70- return nil, fmt.Errorf("first value must be >= 0")
71- }
72-
73- if left >= sliceLen {
74- return nil, fmt.Errorf("first value must be less than number of patches")
75- }
76-
77- if len(items) == 1 {
78- return &Ranger{
79- Left: left,
80- Right: left,
81- }, nil
82- }
83-
84- if items[1] == "" {
85- return &Ranger{Left: left, Right: sliceLen - 1}, nil
86- }
87-
88- right, err := strconv.Atoi(items[1])
89- if err != nil {
90- return nil, fmt.Errorf("second value after `:` must provide number")
91- }
92-
93- if left > right {
94- return nil, fmt.Errorf("second value must be greater than first value")
95- }
96-
97- if right >= sliceLen {
98- return nil, fmt.Errorf("second value must be less than number of patches")
99- }
100-
101- return &Ranger{
102- Left: left,
103- Right: right,
104- }, nil
105-} */
106-
107-/* func gitServiceCommands(sesh ssh.Session, be *Backend, cmd, repoName string) error {
108- name := utils.SanitizeRepo(repoName)
109- // git bare repositories should end in ".git"
110- // https://git-scm.com/docs/gitrepository-layout
111- repoID := be.RepoID(name)
112- reposDir := be.ReposDir()
113- err := git.EnsureWithin(reposDir, repoID)
114- if err != nil {
115- return err
116- }
117- repoPath := filepath.Join(reposDir, repoID)
118- serviceCmd := git.ServiceCommand{
119- Stdin: sesh,
120- Stdout: sesh,
121- Stderr: sesh.Stderr(),
122- Dir: repoPath,
123- Env: sesh.Environ(),
124- }
125-
126- if cmd == "git-receive-pack" {
127- err := git.ReceivePack(sesh.Context(), serviceCmd)
128- if err != nil {
129- return err
130- }
131- } else if cmd == "git-upload-pack" {
132- err := git.UploadPack(sesh.Context(), serviceCmd)
133- if err != nil {
134- return err
135- }
136- }
137-
138- return nil
139-} */
140
141base-commit: 9a160b1d63302a04b1b24e2b17ef8f2b9b6b1040
142--
1432.45.2
144
ps-1
by
erock
on chore: remove dead code
Eric Bower <me@erock.io>
util.go | 111 -------------------------------------------------------- 1 file changed, 111 deletions(-)
1From 3a945b121a7e9a4695bee935fb1785c3d9108d9c Mon Sep 17 00:00:00 2001
2From: Eric Bower <me@erock.io>
3Date: Thu, 18 Jul 2024 14:02:40 -0400
4Subject: [PATCH] chore: remove dead code
5
6---
7 util.go | 111 --------------------------------------------------------
8 1 file changed, 111 deletions(-)
9
10diff --git a/util.go b/util.go
11index 5c6e41e..abb0a68 100644
12--- a/util.go
13+++ b/util.go
14@@ -6,12 +6,10 @@ import (
15 "encoding/hex"
16 "fmt"
17 "io"
18- "log/slog"
19 "math/rand"
20 "regexp"
21 "strconv"
22 "strings"
23- "time"
24
25 "github.com/bluekeyes/go-gitdiff/gitdiff"
26 "github.com/charmbracelet/ssh"
27@@ -211,112 +209,3 @@ func calcContentSha(diffFiles []*gitdiff.File, header *gitdiff.PatchHeader) stri
28 shaStr := hex.EncodeToString(sha[:])
29 return shaStr
30 }
31-
32-func AuthorDateToTime(date string, logger *slog.Logger) time.Time {
33- // TODO: convert sql column to DATETIME
34- ds, err := time.Parse("2006-01-02T15:04:05Z", date)
35- if err != nil {
36- logger.Error(
37- "cannot parse author date for patch",
38- "datetime", date,
39- "err", err,
40- )
41- return time.Now()
42- }
43- return ds
44-}
45-
46-/* func filterPatches(ranger *Ranger, patches []*Patch) []*Patch {
47- if ranger.Left == ranger.Right {
48- return []*Patch{patches[ranger.Left]}
49- }
50- return patches[ranger.Left:ranger.Right]
51-}
52-
53-type Ranger struct {
54- Left int
55- Right int
56-}
57-
58-func parseRange(rnge string, sliceLen int) (*Ranger, error) {
59- items := strings.Split(rnge, ":")
60- left := 0
61- var err error
62- if items[0] != "" {
63- left, err = strconv.Atoi(items[0])
64- if err != nil {
65- return nil, fmt.Errorf("first value before `:` must provide number")
66- }
67- }
68-
69- if left < 0 {
70- return nil, fmt.Errorf("first value must be >= 0")
71- }
72-
73- if left >= sliceLen {
74- return nil, fmt.Errorf("first value must be less than number of patches")
75- }
76-
77- if len(items) == 1 {
78- return &Ranger{
79- Left: left,
80- Right: left,
81- }, nil
82- }
83-
84- if items[1] == "" {
85- return &Ranger{Left: left, Right: sliceLen - 1}, nil
86- }
87-
88- right, err := strconv.Atoi(items[1])
89- if err != nil {
90- return nil, fmt.Errorf("second value after `:` must provide number")
91- }
92-
93- if left > right {
94- return nil, fmt.Errorf("second value must be greater than first value")
95- }
96-
97- if right >= sliceLen {
98- return nil, fmt.Errorf("second value must be less than number of patches")
99- }
100-
101- return &Ranger{
102- Left: left,
103- Right: right,
104- }, nil
105-} */
106-
107-/* func gitServiceCommands(sesh ssh.Session, be *Backend, cmd, repoName string) error {
108- name := utils.SanitizeRepo(repoName)
109- // git bare repositories should end in ".git"
110- // https://git-scm.com/docs/gitrepository-layout
111- repoID := be.RepoID(name)
112- reposDir := be.ReposDir()
113- err := git.EnsureWithin(reposDir, repoID)
114- if err != nil {
115- return err
116- }
117- repoPath := filepath.Join(reposDir, repoID)
118- serviceCmd := git.ServiceCommand{
119- Stdin: sesh,
120- Stdout: sesh,
121- Stderr: sesh.Stderr(),
122- Dir: repoPath,
123- Env: sesh.Environ(),
124- }
125-
126- if cmd == "git-receive-pack" {
127- err := git.ReceivePack(sesh.Context(), serviceCmd)
128- if err != nil {
129- return err
130- }
131- } else if cmd == "git-upload-pack" {
132- err := git.UploadPack(sesh.Context(), serviceCmd)
133- if err != nil {
134- return err
135- }
136- }
137-
138- return nil
139-} */
140
141base-commit: 9a160b1d63302a04b1b24e2b17ef8f2b9b6b1040
142--
1432.45.2
144