dashboard / erock/git-pr / fix: log admin as closer #10 rss

accepted · opened on 2024-07-22T17:56:38Z by jolheiser
Help
checkout latest patchset:
ssh pr.pico.sh print pr-10 | git am -3
checkout any patchset in a patch request:
ssh pr.pico.sh print ps-X | git am -3
add changes to patch request:
git format-patch main --stdout | ssh pr.pico.sh pr add 10
add review to patch request:
git format-patch main --stdout | ssh pr.pico.sh pr add --review 10
accept PR:
ssh pr.pico.sh pr accept 10
close PR:
ssh pr.pico.sh pr close 10

Logs

jolheiser created pr with ps-17 on 2024-07-22T16:07:15Z
erock changed status on 2024-07-22T18:11:16Z {"status":"accepted"}
erock changed status on 2024-12-20T18:23:52Z {"status":"accepted"}

Patchsets

ps-17 by jolheiser on 2024-07-22T16:07:15Z

Patchset ps-17

fix: use eventlog time for pr details

jolheiser
2024-07-22T16:06:49Z
web.go
+2 -2
Back to top

fix: use eventlog time for pr details

Signed-off-by: jolheiser <git@jolheiser.com>
web.go link
+2 -2
 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
diff --git a/web.go b/web.go
index 2e9fed5..95612c6 100644
--- a/web.go
+++ b/web.go
@@ -476,7 +476,7 @@ func prDetailHandler(w http.ResponseWriter, r *http.Request) {
 		w.WriteHeader(http.StatusUnprocessableEntity)
 		return
 	}
-	slices.SortFunc[[]*EventLog](logs, func(a *EventLog, b *EventLog) int {
+	slices.SortFunc(logs, func(a *EventLog, b *EventLog) int {
 		return a.CreatedAt.Compare(b.CreatedAt)
 	})
 
@@ -498,7 +498,7 @@ func prDetailHandler(w http.ResponseWriter, r *http.Request) {
 				IsAdmin: web.Backend.IsAdmin(pk),
 				Pubkey:  user.Pubkey,
 			},
-			Date: pr.CreatedAt.Format(web.Backend.Cfg.TimeFormat),
+			Date: eventlog.CreatedAt.Format(web.Backend.Cfg.TimeFormat),
 		})
 	}