dashboard / erock/git-pr / contrib: add dev script #11 rss

accepted · opened on 2024-07-22T18:12:32Z by jolheiser
Help
checkout latest patchset: 
ssh pr.pico.sh print pr-11 | git am -3
checkout any patchset in a patch request: 
ssh pr.pico.sh print ps-X | git am -3
add changes to patch request: 
git format-patch main --stdout | ssh pr.pico.sh pr add 11
add review to patch request: 
git format-patch main --stdout | ssh pr.pico.sh pr add --review 11
accept PR: 
ssh pr.pico.sh pr accept 11
close PR: 
ssh pr.pico.sh pr close 11

Logs

jolheiser created pr with ps-18 on 2024-07-22T16:35:13Z
erock added ps-22 on 2024-07-22T18:12:49Z
erock changed status on 2024-07-22T18:12:49Z {"status":"accepted"}

Patchsets

ps-18 by jolheiser on 2024-07-22T16:35:13Z
Range Diff ↕ rd-22
-: ------- > 1: 31fcd4a lgtm
1: 57b42aa = 2: 31fcd4a fix: only log status change if the status changes
ps-22 by erock on 2024-07-22T18:12:49Z

Patchset ps-22

REVIEW lgtm

Eric Bower
2024-07-22T18:12:25Z

fix: only log status change if the status changes

jolheiser
2024-07-22T16:34:57Z
cli.go
+1 -1
Back to top

lgtm

woops! thanks for fixing that

jolheiser (1):
  fix: only log status change if the status changes

 cli.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

base-commit: dbedbf6c422822dfdaaded07103829f8bb85d11a
--
2.45.2

fix: only log status change if the status changes

Signed-off-by: jolheiser <git@jolheiser.com>
cli.go link
+1 -1 
 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13

diff --git a/cli.go b/cli.go
index 93869c8..40d9a04 100644
--- a/cli.go
+++ b/cli.go
@@ -810,7 +810,7 @@ Here's how it works:
 								return nil
 							}
 
-							if nextStatus != "" {
+							if prq.Status != nextStatus {
 								err = pr.UpdatePatchRequestStatus(prID, user.ID, nextStatus)
 								if err != nil {
 									return err