git-pr / docs: fix typo / minor rewording in readme #8

accepted · opened on 2024-07-20T15:02:56Z by exelotl
Help 
# add changes to patch request
git format-patch main --stdout | ssh pr.pico.sh pr add 8
# add review to patch request
git format-patch main --stdout | ssh pr.pico.sh pr add --review 8
# remove patchset
ssh pr.pico.sh ps rm ps-x
# checkout all patches
ssh pr.pico.sh pr print 8 | git am -3
# print a diff between the last two patches in a patch request
ssh pr.pico.sh pr diff 8
# accept PR
ssh pr.pico.sh pr accept 8
# close PR
ssh pr.pico.sh pr close 8

Logs

exelotl created pr with ps-14 on 2024-07-20T15:02:56Z
erock reviewed pr with ps-15 on 2024-07-21T15:50:45Z
erock changed status on 2024-07-21T15:50:45Z {"status":"reviewed"}
erock changed status on 2024-07-21T15:51:14Z {"status":"accepted"}

Patchsets

Diff ↕

docs: fix typo / minor rewording in readme

Jeremy Clarke <gecko@exelo.tl> 
 README.md | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
 1From 3ba22c25c3f842f23442d679313ca4a083816f8f Mon Sep 17 00:00:00 2001
 2From: Jeremy Clarke <gecko@exelo.tl>
 3Date: Sat, 20 Jul 2024 15:59:21 +0100
 4Subject: [PATCH] docs: fix typo / minor rewording in readme
 5
 6---
 7 README.md | 10 +++++-----
 8 1 file changed, 5 insertions(+), 5 deletions(-)
 9
10diff --git a/README.md b/README.md
11index ee341c4..d8182e6 100644
12--- a/README.md
13+++ b/README.md
14@@ -124,11 +124,11 @@ git push origin main
15 # Done!
16 ```
17 
18-The fundamental collaboration tool here is `format-patch`. Whether you a
19-submitting code changes or you are reviewing code changes, it all happens in
20-code. Both contributor and owner are simply creating new commits and generating
21-patches on top of each other. This obviates the need to have a web viewer where
22-the reviewer can "comment" on a line of code block. There's no need, apply the
23+The fundamental collaboration tool here is `format-patch`. Whether you are
24+submitting code changes or reviewing them, it all happens in code. Both
25+contributor and owner are simply creating new commits and generating patches
26+on top of each other. This obviates the need to have a web viewer where the
27+reviewer can "comment" on a line of code block. There's no need, apply the
28 contributor's patches, write comments or code changes, generate a new patch,
29 send the patch to the git server as a "review." This flow also works the exact
30 same if two users are collaborating on a set of changes.
31-- 
322.45.2
33
ps-14 by exelotl on 2024-07-20T15:02:56Z
Diff ↕

REVIEW LGTM

Eric Bower <me@erock.io> 
Thanks for your contribution!

Jeremy Clarke (1):
  docs: fix typo / minor rewording in readme

 README.md | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

base-commit: 80146055f2be0bdbd62f2509738ca548451fcdbc
--
2.45.2
 1From e0820267b490275e828d076e650090d86730960f Mon Sep 17 00:00:00 2001
 2From: Eric Bower <me@erock.io>
 3Date: Sun, 21 Jul 2024 11:50:00 -0400
 4Subject: [PATCH 0/1] LGTM
 5
 6Thanks for your contribution!
 7
 8Jeremy Clarke (1):
 9  docs: fix typo / minor rewording in readme
10
11 README.md | 10 +++++-----
12 1 file changed, 5 insertions(+), 5 deletions(-)
13
14
15base-commit: 80146055f2be0bdbd62f2509738ca548451fcdbc
16-- 
172.45.2
ps-15 by erock on 2024-07-21T15:50:45Z

REVIEW LGTM

Eric Bower <me@erock.io> 2024-07-21T15:50:00Z 
Thanks for your contribution!

Jeremy Clarke (1):
  docs: fix typo / minor rewording in readme

 README.md | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

base-commit: 80146055f2be0bdbd62f2509738ca548451fcdbc
--
2.45.2
 1From e0820267b490275e828d076e650090d86730960f Mon Sep 17 00:00:00 2001
 2From: Eric Bower <me@erock.io>
 3Date: Sun, 21 Jul 2024 11:50:00 -0400
 4Subject: [PATCH 0/1] LGTM
 5
 6Thanks for your contribution!
 7
 8Jeremy Clarke (1):
 9  docs: fix typo / minor rewording in readme
10
11 README.md | 10 +++++-----
12 1 file changed, 5 insertions(+), 5 deletions(-)
13
14
15base-commit: 80146055f2be0bdbd62f2509738ca548451fcdbc
16-- 
172.45.2

docs: fix typo / minor rewording in readme

Jeremy Clarke <gecko@exelo.tl> 2024-07-20T14:59:21Z 
 README.md | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
 1From e0820267b490275e828d076e650090d86730960f Mon Sep 17 00:00:00 2001
 2From: Jeremy Clarke <gecko@exelo.tl>
 3Date: Sat, 20 Jul 2024 15:59:21 +0100
 4Subject: [PATCH 1/1] docs: fix typo / minor rewording in readme
 5
 6---
 7 README.md | 10 +++++-----
 8 1 file changed, 5 insertions(+), 5 deletions(-)
 9
10diff --git a/README.md b/README.md
11index ee341c4..d8182e6 100644
12--- a/README.md
13+++ b/README.md
14@@ -124,11 +124,11 @@ git push origin main
15 # Done!
16 ```
17 
18-The fundamental collaboration tool here is `format-patch`. Whether you a
19-submitting code changes or you are reviewing code changes, it all happens in
20-code. Both contributor and owner are simply creating new commits and generating
21-patches on top of each other. This obviates the need to have a web viewer where
22-the reviewer can "comment" on a line of code block. There's no need, apply the
23+The fundamental collaboration tool here is `format-patch`. Whether you are
24+submitting code changes or reviewing them, it all happens in code. Both
25+contributor and owner are simply creating new commits and generating patches
26+on top of each other. This obviates the need to have a web viewer where the
27+reviewer can "comment" on a line of code block. There's no need, apply the
28 contributor's patches, write comments or code changes, generate a new patch,
29 send the patch to the git server as a "review." This flow also works the exact
30 same if two users are collaborating on a set of changes.
31-- 
322.45.2
33