dashboard / erock/git-pr / fix: use eventlog time for pr details #8 rss

accepted · opened on 2024-07-22T16:07:15Z by jolheiser
Help
checkout latest patchset: 
ssh pr.pico.sh print pr-8 | git am -3
checkout any patchset in a patch request: 
ssh pr.pico.sh print ps-X | git am -3
add changes to patch request: 
git format-patch main --stdout | ssh pr.pico.sh pr add 8
add review to patch request: 
git format-patch main --stdout | ssh pr.pico.sh pr add --review 8
accept PR: 
ssh pr.pico.sh pr accept 8
close PR: 
ssh pr.pico.sh pr close 8

Logs

exelotl created pr with ps-14 on 2024-07-20T15:02:56Z
erock reviewed pr with ps-15 on 2024-07-21T15:50:45Z
erock changed status on 2024-07-21T15:50:45Z {"status":"reviewed"}
erock changed status on 2024-07-21T15:51:14Z {"status":"accepted"}

Patchsets

ps-14 by exelotl on 2024-07-20T15:02:56Z
Range Diff ↕ rd-15
-: ------- > 1: e082026 LGTM
1: 3ba22c2 = 2: e082026 docs: fix typo / minor rewording in readme
ps-15 by erock on 2024-07-21T15:50:45Z

Patchset ps-15

REVIEW LGTM

Eric Bower
2024-07-21T15:50:00Z

docs: fix typo / minor rewording in readme

Jeremy Clarke
2024-07-20T14:59:21Z
README.md
+5 -5
Back to top

LGTM

Thanks for your contribution!

Jeremy Clarke (1):
  docs: fix typo / minor rewording in readme

 README.md | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

base-commit: 80146055f2be0bdbd62f2509738ca548451fcdbc
--
2.45.2

docs: fix typo / minor rewording in readme

README.md link
+5 -5 
 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21

diff --git a/README.md b/README.md
index ee341c4..d8182e6 100644
--- a/README.md
+++ b/README.md
@@ -124,11 +124,11 @@ git push origin main
 # Done!
 ```
 
-The fundamental collaboration tool here is `format-patch`. Whether you a
-submitting code changes or you are reviewing code changes, it all happens in
-code. Both contributor and owner are simply creating new commits and generating
-patches on top of each other. This obviates the need to have a web viewer where
-the reviewer can "comment" on a line of code block. There's no need, apply the
+The fundamental collaboration tool here is `format-patch`. Whether you are
+submitting code changes or reviewing them, it all happens in code. Both
+contributor and owner are simply creating new commits and generating patches
+on top of each other. This obviates the need to have a web viewer where the
+reviewer can "comment" on a line of code block. There's no need, apply the
 contributor's patches, write comments or code changes, generate a new patch,
 send the patch to the git server as a "review." This flow also works the exact
 same if two users are collaborating on a set of changes.