dashboard / erock/pico / fix(rsync): delete largest path first #98 rss

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19

diff --git a/pkg/send/protocols/rsync/rsync.go b/pkg/send/protocols/rsync/rsync.go
index a50d0c2..765142e 100644
--- a/pkg/send/protocols/rsync/rsync.go
+++ b/pkg/send/protocols/rsync/rsync.go
@@ -153,6 +153,14 @@ func (h *handler) Remove(willReceive []*rsyncutils.ReceiverFile) error {
 		}
 	}
 
+	// Sort by path depth descending so children are deleted before parents.
+	// This ensures directories are empty before we try to remove them.
+	slices.SortFunc(toDelete, func(a, b string) int {
+		depthA := strings.Count(a, "/")
+		depthB := strings.Count(b, "/")
+		return depthB - depthA
+	})
+
 	var errs []error
 
 	for _, file := range toDelete {