feat(prose): live journal

jolheiser created pr with ps-20 on 2024-07-22T17:56:38Z

erock reviewed pr with ps-23 on 2024-07-22T18:28:48Z

erock changed status on 2024-07-22T18:28:48Z {"status":"reviewed"}

ps-20 by jolheiser on 2024-07-22T17:56:38Z

Range Diff ↕ rd-23


                -:  ------- > 1:  0d8b33f lgtm


                1:  1743c59 ! 2:  49da24b fix: log admin as closer


                -:  ------- > 3:  0d8b33f chore: update `pr reopen` cmd as well

ps-23 by erock on 2024-07-22T18:28:48Z

Patchset `ps-20`

jolheiser

2024-07-22T17:56:18Z

cli.go

+7 -2

Previously the contributor was logged as the closer, even when an admin closed a pr

Signed-off-by: jolheiser <git@jolheiser.com>

cli.go link

+7 -2

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32


diff --git a/cli.go b/cli.go
index 93869c8..7d6da9c 100644
--- a/cli.go
+++ b/cli.go
@@ -619,13 +619,13 @@ Here's how it works:
 								return err
 							}
 
-							user, err := pr.GetUserByID(patchReq.UserID)
+							patchUser, err := pr.GetUserByID(patchReq.UserID)
 							if err != nil {
 								return err
 							}
 
 							pk := sesh.PublicKey()
-							isContrib := pubkey == user.Pubkey
+							isContrib := pubkey == patchUser.Pubkey
 							isAdmin := be.IsAdmin(pk)
 							if !isAdmin && !isContrib {
 								return fmt.Errorf("you are not authorized to change PR status")
@@ -635,6 +635,11 @@ Here's how it works:
 								return fmt.Errorf("PR has already been closed")
 							}
 
+							user, err := pr.UpsertUser(pubkey, userName)
+							if err != nil {
+								return err
+							}
+
 							err = pr.UpdatePatchRequestStatus(prID, user.ID, "closed")
 							if err != nil {
 								return err