pubsub
created pr with
pubsub/28.1
added pubsub/28.2
1: 57a5727 = 1: 57a5727 refactor: create remote client lib
-: ------- > 2: 67d38ff refactor(log): rm ConnectToLogs
added pubsub/28.3
1: 57a5727 = 1: 57a5727 refactor: create remote client lib
2: 67d38ff = 2: 67d38ff refactor(log): rm ConnectToLogs
-: ------- > 3: 97084b4 refactor(log): preserve `ConnectToLogs` but make it a convenient proxy
added pubsub/28.4
1: 57a5727 = 1: 57a5727 refactor: create remote client lib
2: 67d38ff ! 2: 866d44c refactor(log): `ConnectToLogs`
3: 97084b4 < -: ------- refactor(log): preserve `ConnectToLogs` but make it a convenient proxy
cmds
checkout latest patchset:
ssh pr.pico.sh pull pubsub:28 | git am -3checkout specific patchset revision:
ssh pr.pico.sh pull pubsub:28 [rev] | git am -3add changes to patch request:
git format-patch main --stdout | ssh pr.pico.sh pubsub:28add comment to patch request:
ssh pr.pico.sh comment pubsub:28 "lgtm!"
Patchset
pubsub/28.3
refactor(log): preserve `ConnectToLogs` but make it a convenient proxy
Eric Bower
2024-11-12T15:12:51ZSemantic diff summary
1 added,
0 modified,
0 signature changed,
0 removed
across 1 analyzed file
+4
-0
log/log.go
#
| ... | ... | @@ -270,3 +270,7 @@ func SendLogRegister(logger *slog.Logger, connectionInfo *pubsub.RemoteClientInf | |
| 270 | 270 | ||
| 271 | 271 | var _ io.Writer = (*PubSubLogWriter)(nil) | |
| 272 | 272 | var _ slog.Handler = (*MultiHandler)(nil) | |
| 273 | + | ||
| 274 | + | func ConnectToLogs(ctx context.Context, connectionInfo *pubsub.RemoteClientInfo) (io.Reader, error) { | |
| 275 | + | return pubsub.RemoteSub("sub log-drain -k", ctx, connectionInfo) | |
| 276 | + | } |