pico

chore(pubsub): add more tests open rss

created pr with 105.1 on 2026-01-25T17:03:08Z · by c8ef7d19

added 105.2 on 2026-01-27T04:11:48Z · by c8ef7d19


                      1:  603ca6e = 1:  603ca6e chore(pubsub): add more tests


                      2:  501c042 ! 2:  17e00b2 feat(pubsub): round robin

added 105.3 on 2026-01-29T01:03:33Z · by c8ef7d19


                      1:  603ca6e = 1:  603ca6e chore(pubsub): add more tests


                      2:  17e00b2 = 2:  17e00b2 feat(pubsub): round robin


                      -:  ------- > 3:  e3136bd fix(pubsub): check for eof before processing and skip empty byte reads


                      -:  ------- > 4:  9a6d19e fix: rr


                      -:  ------- > 5:  5b3f3a1 fix: sending 0 byte read

added 105.4 on 2026-02-01T17:16:43Z · by c8ef7d19


                      1:  603ca6e = 1:  603ca6e chore(pubsub): add more tests


                      2:  17e00b2 = 2:  17e00b2 feat(pubsub): round robin


                      3:  e3136bd = 3:  e3136bd fix(pubsub): check for eof before processing and skip empty byte reads


                      4:  9a6d19e = 4:  9a6d19e fix: rr


                      5:  5b3f3a1 = 5:  5b3f3a1 fix: sending 0 byte read


                      -:  ------- > 6:  4fff471 refactor: fixes


                      -:  ------- > 7:  d0dfc85 chore: SetDispatch on Broker

changed status to accepted on 2026-02-23T02:02:07Z · by c8ef7d19

cmds

checkout latest patchset:

ssh pr.pico.sh print 105 | git am -3

checkout any patchset in a patch request:

ssh pr.pico.sh print 105.[rev] | git am -3

add changes to patch request:

git format-patch main --stdout | ssh pr.pico.sh pr add 105

set PR to open (enables RSS notifications):

ssh pr.pico.sh pr open 105

set PR to draft (stops RSS notifications):

ssh pr.pico.sh pr draft 105

Patchset `105.3` on 2026-01-29T01:03:32Z · commit e3136bd

chore(pubsub): add more tests

Eric Bower 2026-01-25T16:38:25Z

feat(pubsub): round robin

Eric Bower 2026-01-25T16:38:25Z

→ fix(pubsub): check for eof before processing and skip empty byte reads

Eric Bower 2026-01-28T01:42:34Z

fix: rr

Eric Bower 2026-01-28T01:50:04Z

fix: sending 0 byte read

Eric Bower 2026-01-28T02:50:25Z

fix(pubsub): check for eof before processing and skip empty byte reads

Eric Bower 2026-01-28T01:42:34Z

Semantic diff summary

0 added, 1 modified, 0 signature changed, 0 removed across 1 analyzed file

pkg/pubsub/broker.go

function_declaration Connect modified

+15 -8 pkg/pubsub/broker.go #

......@@ -104,6 +104,21 @@ func (b *BaseBroker) Connect(client *Client, channels []*Channel) (error, error)
			for {
				data := make([]byte, 32*1024)
				n, err := client.ReadWriter.Read(data)

				// Check for EOF before processing
				if err != nil {
					if errors.Is(err, io.EOF) {
						return
					}
					inputErr = err
					return
				}

				// Skip empty reads
				if n == 0 {
					continue
				}

				data = data[:n]

				channelMessage := ChannelMessage{

......@@ -152,14 +167,6 @@ func (b *BaseBroker) Connect(client *Client, channels []*Channel) (error, error)
				}

				sendwg.Wait()

				if err != nil {
					if errors.Is(err, io.EOF) {
						return
					}
					inputErr = err
					return
				}
			}
		}()
	}

...	...		@@ -104,6 +104,21 @@ func (b BaseBroker) Connect(client Client, channels []*Channel) (error, error)
104	104		for {
105	105		data := make([]byte, 32*1024)
106	106		n, err := client.ReadWriter.Read(data)
	107	+
	108	+	// Check for EOF before processing
	109	+	if err != nil {
	110	+	if errors.Is(err, io.EOF) {
	111	+	return
	112	+	}
	113	+	inputErr = err
	114	+	return
	115	+	}
	116	+
	117	+	// Skip empty reads
	118	+	if n == 0 {
	119	+	continue
	120	+	}
	121	+
107	122		data = data[:n]
108	123
109	124		channelMessage := ChannelMessage{

...	...		@@ -152,14 +167,6 @@ func (b BaseBroker) Connect(client Client, channels []*Channel) (error, error)
152	167		}
153	168
154	169		sendwg.Wait()
155		-
156		-	if err != nil {
157		-	if errors.Is(err, io.EOF) {
158		-	return
159		-	}
160		-	inputErr = err
161		-	return
162		-	}
163	170		}
164	171		}()
165	172		}

pico

Patchset 105.3 on 2026-01-29T01:03:32Z · commit e3136bd

Patchset `105.3` on 2026-01-29T01:03:32Z · commit e3136bd