borogove/sdk
created pr with
134.1
cmds
checkout latest patchset:
ssh pr.pico.sh print 134 | git am -3checkout any patchset in a patch request:
ssh pr.pico.sh print 134.[rev] | git am -3add changes to patch request:
git format-patch main --stdout | ssh pr.pico.sh pr add 134
Patchset
134.1
Rename Import to Importer
Eric Roberts
2026-08-12T17:31:34ZMacOS by default has a case insensitive file system and import.hx is something special to Haxe so it causes problems. Renaming to Importer.hx fixes this.
Semantic diff summary
0 added,
1 modified,
0 signature changed,
0 removed
across 1 analyzed file
(5 files skipped: unsupported file type)
+1
-1
borogove/Importer.hx
#
+1
-1
browserjs.hxml
#
+1
-1
nodejs.hxml
#
+1
-1
npm/index.ts
#
| ... | ... | @@ -31,7 +31,7 @@ export { | |
| 31 | 31 | borogove_Hash as Hash, | |
| 32 | 32 | borogove_Html as Html, | |
| 33 | 33 | borogove_Identicon as Identicon, | |
| 34 | - | borogove_Import as Import, | |
| 34 | + | borogove_Importer as Importer, | |
| 35 | 35 | borogove_LinkMetadata as LinkMetadata, | |
| 36 | 36 | borogove_Notification as Notification, | |
| 37 | 37 | borogove_Member as Member, |
+1
-1
test/TestAll.hx
#
+7
-7
test/TestImporter.hx
#
| ... | ... | @@ -2,15 +2,15 @@ package test; | |
| 2 | 2 | ||
| 3 | 3 | import utest.Assert; | |
| 4 | 4 | ||
| 5 | - | import borogove.Import; | |
| 5 | + | import borogove.Importer; | |
| 6 | 6 | import borogove.Message; | |
| 7 | 7 | import borogove.JID; | |
| 8 | 8 | ||
| 9 | - | class TestImport extends utest.Test { | |
| 9 | + | class TestImporter extends utest.Test { | |
| 10 | 10 | public function testOnAccount() { | |
| 11 | 11 | final accounts = []; | |
| 12 | 12 | ||
| 13 | - | final i = new Import(null); | |
| 13 | + | final i = new Importer(null); | |
| 14 | 14 | i.onAccount = (id) -> { | |
| 15 | 15 | accounts.push(id); | |
| 16 | 16 | }; |