borogove/sdk

Rename Import to Importer open rss
created pr with 134.1 on 2026-08-12T17:34:27Z · by 3c31bc8c
changed status to open on 2026-08-12T17:34:46Z · by 3c31bc8c
cmds
checkout latest patchset: 
ssh pr.pico.sh print 134 | git am -3
checkout any patchset in a patch request: 
ssh pr.pico.sh print 134.[rev] | git am -3
add changes to patch request: 
git format-patch main --stdout | ssh pr.pico.sh pr add 134
set PR to open (enables RSS notifications): 
ssh pr.pico.sh pr open 134
set PR to draft (stops RSS notifications): 
ssh pr.pico.sh pr draft 134

Patchset 134.1 on 2026-08-12T17:34:27Z · commit bde450d

→ Rename Import to Importer
Eric Roberts 2026-08-12T17:31:34Z
Rename Import to Importer
Eric Roberts 2026-08-12T17:31:34Z
MacOS by default has a case insensitive file system and import.hx is something
special to Haxe so it causes problems. Renaming to Importer.hx fixes this.
Semantic diff summary
0 added, 1 modified, 0 signature changed, 0 removed across 1 analyzed file (5 files skipped: unsupported file type)
npm/index.ts
+1 -1 borogove/Importer.hx # 
@@ -7,7 +7,7 @@ import borogove.Chat;
 
 @:expose
 @:access(Xml)
-class Import {
+class Importer {
 	private final p: Sax;
 	private final targetAccount: Null<String>;
 	private var sortA: String;
+1 -1 browserjs.hxml # 
@@ -16,7 +16,7 @@ borogove.Push
 borogove.Version
 borogove.persistence.Sqlite
 borogove.Html
-borogove.Import
+borogove.Importer
 
 -D analyzer-optimize
 -D js-es=6
+1 -1 nodejs.hxml # 
@@ -18,7 +18,7 @@ borogove.Version
 borogove.persistence.Sqlite
 borogove.persistence.MediaStoreFS
 borogove.Html
-borogove.Import
+borogove.Importer
 
 --macro borogove.Util.DummyRequireMacro.init()
 -D analyzer-optimize
+1 -1 npm/index.ts # 
@@ -31,7 +31,7 @@ export {
     borogove_Hash as Hash,
     borogove_Html as Html,
     borogove_Identicon as Identicon,
-    borogove_Import as Import,
+    borogove_Importer as Importer,
     borogove_LinkMetadata as LinkMetadata,
     borogove_Notification as Notification,
     borogove_Member as Member,
+1 -1 test/TestAll.hx # 
@@ -21,7 +21,7 @@ class TestAll {
 			new TestClient(),
 			new TestEmojiUtil(),
 			new TestHtml(),
-			new TestImport(),
+			new TestImporter(),
 			new TestJID(),
 			new TestMember(),
 			new TestMemberUpdate(),
+7 -7 test/TestImporter.hx # 
@@ -2,15 +2,15 @@ package test;
 
 import utest.Assert;
 
-import borogove.Import;
+import borogove.Importer;
 import borogove.Message;
 import borogove.JID;
 
-class TestImport extends utest.Test {
+class TestImporter extends utest.Test {
 	public function testOnAccount() {
 		final accounts = [];
 
-		final i = new Import(null);
+		final i = new Importer(null);
 		i.onAccount = (id) -> {
 			accounts.push(id);
 		};

@@ -31,7 +31,7 @@ class TestImport extends utest.Test {
 	public function testOnChannel() {
 		final channels = [];
 
-		final i = new Import(null);
+		final i = new Importer(null);
 		i.onChannel = (id) -> {
 			channels.push(id);
 		};

@@ -51,7 +51,7 @@ class TestImport extends utest.Test {
 	public function testOnMamItem() {
 		final items = [];
 
-		final i = new Import(null);
+		final i = new Importer(null);
 		i.onMessage = (source, msg) -> {
 			items.push(msg);
 		};

@@ -91,7 +91,7 @@ class TestImport extends utest.Test {
 	public function testTargetAccount() {
 		final items = [];
 
-		final i = new Import("me@example.com");
+		final i = new Importer("me@example.com");
 		i.onMessage = (source, msg) -> {
 			items.push(msg);
 		};

@@ -127,7 +127,7 @@ class TestImport extends utest.Test {
 	public function testTimestampFixing() {
 		final items = [];
 
-		final i = new Import(null);
+		final i = new Importer(null);
 		i.onMessage = (source, msg) -> {
 			items.push(msg);
 		};
Back to top