git-pr

feat: static assets open rss

created pr with 3.1 on 2024-07-19T14:53:23Z · by c8ef7d19

added 3.2 on 2024-07-19T14:55:48Z · by c8ef7d19


                      1:  3b99dc0 < -:  ------- feat: static assets


                      2:  8919af5 ! 1:  66cafc6 feat: static assets folder


                      3:  7346122 ! 2:  5e76ed3 fix(cli): access control for removing patchsets


                      4:  d8792d5 < -:  ------- feat: static folder

pr_reviewed on 2024-07-19T15:42:29Z · by 964fa508

changed status to reviewed on 2024-07-19T15:42:29Z · by 964fa508

added 3.4 on 2024-07-19T17:43:47Z · by c8ef7d19


                      1:  cc56ea1 = 1:  0467f9e feat: static assets folder


                      2:  ef749a4 = 2:  da1730f review: typo and future enhancement comment


                      -:  ------- > 3:  c038404 refactor: per-file override for static folder

changed status to accepted on 2024-07-19T18:27:53Z · by 964fa508

cmds

checkout latest patchset:

ssh pr.pico.sh print 3 | git am -3

checkout any patchset in a patch request:

ssh pr.pico.sh print 3.[rev] | git am -3

add changes to patch request:

git format-patch main --stdout | ssh pr.pico.sh pr add 3

set PR to open (enables RSS notifications):

ssh pr.pico.sh pr open 3

set PR to draft (stops RSS notifications):

ssh pr.pico.sh pr draft 3

Patchset `3.4` on 2024-07-19T17:43:47Z · commit da1730f

feat: static assets folder

Eric Bower 2024-07-19T04:27:17Z

→ review: typo and future enhancement comment

jolheiser 2024-07-19T15:40:15Z

refactor: per-file override for static folder

Eric Bower 2024-07-19T17:43:12Z

review: typo and future enhancement comment

jolheiser 2024-07-19T15:40:15Z

Signed-off-by: jolheiser <git@jolheiser.com>

Semantic diff summary

0 added, 1 modified, 0 signature changed, 0 removed across 1 analyzed file

web.go

function_declaration serveFile modified

+3 -0 web.go #

......@@ -663,6 +663,9 @@ func serveFile(staticfs fs.FS) func(w http.ResponseWriter, r *http.Request) {
	}
}

// review(jolheiser):
// Perhaps in the future this could be extended to support per-file. For example, I may want to override CSS vars without providing an entire static assets.
// embeded -> embedded
func getFileSystem(logger *slog.Logger, ffs embed.FS, datadir string, dirName string) (fs.FS, error) {
	dir := filepath.Join(datadir, dirName)
	_, err := os.Stat(dir)

...	...		@@ -663,6 +663,9 @@ func serveFile(staticfs fs.FS) func(w http.ResponseWriter, r *http.Request) {
663	663		}
664	664		}
665	665
	666	+	// review(jolheiser):
	667	+	// Perhaps in the future this could be extended to support per-file. For example, I may want to override CSS vars without providing an entire static assets.
	668	+	// embeded -> embedded
666	669		func getFileSystem(logger *slog.Logger, ffs embed.FS, datadir string, dirName string) (fs.FS, error) {
667	670		dir := filepath.Join(datadir, dirName)
668	671		_, err := os.Stat(dir)

git-pr

Patchset 3.4 on 2024-07-19T17:43:47Z · commit da1730f

Patchset `3.4` on 2024-07-19T17:43:47Z · commit da1730f