send

fix(sftp): only call `writeHandler.Write` once during PUT rss

created pr with 40.1 on 2025-01-10T02:33:23Z · by c8ef7d19

cmds

checkout latest patchset:

ssh pr.pico.sh print 40 | git am -3

checkout any patchset in a patch request:

ssh pr.pico.sh print 40.[rev] | git am -3

add changes to patch request:

git format-patch main --stdout | ssh pr.pico.sh pr add 40

Patchset `40.1` on 2025-01-10T02:33:23Z · commit a468495

→ fix(sftp): only call `writeHandler.Write` once during PUT

Eric Bower 2025-01-10T02:32:49Z

fix(sftp): only call `writeHandler.Write` once during PUT

Eric Bower 2025-01-10T02:32:49Z

Semantic diff summary

0 added, 2 modified, 0 signature changed, 0 removed across 1 analyzed file

protocols/sftp/handler.go

chunk lines 1-6 modified
method_declaration Filewrite modified

+0 -8 protocols/sftp/handler.go #

......@@ -1,7 +1,6 @@
package sftp

import (
	"bytes"
	"errors"
	"io"
	"io/fs"

......@@ -118,13 +117,6 @@ func toFileEntry(r *sftp.Request) *utils.FileEntry {

func (f *handler) Filewrite(r *sftp.Request) (io.WriterAt, error) {
	entry := toFileEntry(r)
	entry.Reader = bytes.NewReader([]byte{})

	_, err := f.writeHandler.Write(f.session, entry)
	if err != nil {
		return nil, err
	}

	buf := &buffer{}
	entry.Reader = buf

...	...		@@ -118,13 +117,6 @@ func toFileEntry(r sftp.Request) utils.FileEntry {
118	117
119	118		func (f handler) Filewrite(r sftp.Request) (io.WriterAt, error) {
120	119		entry := toFileEntry(r)
121		-	entry.Reader = bytes.NewReader([]byte{})
122		-
123		-	_, err := f.writeHandler.Write(f.session, entry)
124		-	if err != nil {
125		-	return nil, err
126		-	}
127		-
128	120		buf := &buffer{}
129	121		entry.Reader = buf
130	122

...	...		@@ -1,7 +1,6 @@
1	1		package sftp
2	2
3	3		import (
4		-	"bytes"
5	4		"errors"
6	5		"io"
7	6		"io/fs"

send

Patchset 40.1 on 2025-01-10T02:33:23Z · commit a468495

Patchset `40.1` on 2025-01-10T02:33:23Z · commit a468495