vaxis

vxfw(List): add `Gap` between list items rss

created pr with 51.1 on 2025-03-12T17:28:45Z · by c8ef7d19

cmds

checkout latest patchset:

ssh pr.pico.sh print 51 | git am -3

checkout any patchset in a patch request:

ssh pr.pico.sh print 51.[rev] | git am -3

add changes to patch request:

git format-patch main --stdout | ssh pr.pico.sh pr add 51

Patchset `51.1` on 2025-03-12T17:28:45Z · commit 394e1cf

→ vxfw(List): add `Gap` between list items

Eric Bower 2025-03-12T17:27:43Z

vxfw(List): add `Gap` between list items

Eric Bower 2025-03-12T17:27:43Z

Semantic diff summary

0 added, 3 modified, 0 signature changed, 0 removed across 2 analyzed files

_examples/vxfw/list/main.go

function_declaration main modified

vxfw/list/list.go

chunk lines 23-31 modified
function_declaration Draw modified

+1 -0 _examples/vxfw/list/main.go #

......@@ -79,6 +79,7 @@ func main() {
		list: list.Dynamic{
			Builder:    getWidget,
			DrawCursor: true,
			Gap: 1,
		},
	}

+5 -2 vxfw/list/list.go #

......@@ -23,6 +23,9 @@ type Dynamic struct {
	// events. Set this to true to use custom event handlers
	DisableEventHandlers bool

	// Distance between each list item
	Gap int

	cursor uint
	scroll scroll
}

......@@ -180,7 +183,7 @@ func (d *Dynamic) Draw(ctx vxfw.DrawContext) (vxfw.Surface, error) {
		s.AddChild(colOffset, ah, chS)

		// Add our height to accumulated height
		ah += int(chS.Size.Height)
		ah += int(chS.Size.Height) + d.Gap

		// If we need to draw the cursor, keep going
		if d.scroll.wantsCursor && i <= d.cursor {

......@@ -194,7 +197,7 @@ func (d *Dynamic) Draw(ctx vxfw.DrawContext) (vxfw.Surface, error) {

	var totalHeight uint16
	for _, ch := range s.Children {
		totalHeight += ch.Surface.Size.Height
		totalHeight += ch.Surface.Size.Height + uint16(d.Gap)
	}

	if d.DrawCursor {

...	...		@@ -79,6 +79,7 @@ func main() {
79	79		list: list.Dynamic{
80	80		Builder: getWidget,
81	81		DrawCursor: true,
	82	+	Gap: 1,
82	83		},
83	84		}
84	85

...	...		@@ -23,6 +23,9 @@ type Dynamic struct {
23	23		// events. Set this to true to use custom event handlers
24	24		DisableEventHandlers bool
25	25
	26	+	// Distance between each list item
	27	+	Gap int
	28	+
26	29		cursor uint
27	30		scroll scroll
28	31		}

...	...		@@ -180,7 +183,7 @@ func (d *Dynamic) Draw(ctx vxfw.DrawContext) (vxfw.Surface, error) {
180	183		s.AddChild(colOffset, ah, chS)
181	184
182	185		// Add our height to accumulated height
183		-	ah += int(chS.Size.Height)
	186	+	ah += int(chS.Size.Height) + d.Gap
184	187
185	188		// If we need to draw the cursor, keep going
186	189		if d.scroll.wantsCursor && i <= d.cursor {

...	...		@@ -194,7 +197,7 @@ func (d *Dynamic) Draw(ctx vxfw.DrawContext) (vxfw.Surface, error) {
194	197
195	198		var totalHeight uint16
196	199		for _, ch := range s.Children {
197		-	totalHeight += ch.Surface.Size.Height
	200	+	totalHeight += ch.Surface.Size.Height + uint16(d.Gap)
198	201		}
199	202
200	203		if d.DrawCursor {

vaxis

Patchset 51.1 on 2025-03-12T17:28:45Z · commit 394e1cf

Patchset `51.1` on 2025-03-12T17:28:45Z · commit 394e1cf