pico
created pr with
66.1
changed pr name to
chore(pobj.fs): feature parity with minio
added 66.2
1: a3f9ef2 = 1: a3f9ef2 chore: rm UserMetadata
2: ccd89b0 = 2: ccd89b0 refactor(shared): mime type pkg
3: 8621e35 = 3: 8621e35 chore(pobj.fs): provide metadata
-: ------- > 4: 831b150 chore(storage.fs): add tests
cmds
checkout latest patchset:
ssh pr.pico.sh print 66 | git am -3checkout any patchset in a patch request:
ssh pr.pico.sh print 66.[rev] | git am -3add changes to patch request:
git format-patch main --stdout | ssh pr.pico.sh pr add 66
Patchset
66.2
chore: rm UserMetadata
Eric Bower
2025-04-18T17:01:42ZSemantic diff summary
0 added,
4 modified,
0 signature changed,
0 removed
across 4 analyzed files
+0
-1
pkg/pobj/storage/fs.go
#
| ... | ... | @@ -97,7 +97,6 @@ func (s *StorageFS) GetObject(bucket Bucket, fpath string) (utils.ReadAndReaderA | |
| 97 | 97 | objInfo := &ObjectInfo{ | |
| 98 | 98 | LastModified: time.Time{}, | |
| 99 | 99 | Metadata: nil, | |
| 100 | - | UserMetadata: map[string]string{}, | |
| 101 | 100 | } | |
| 102 | 101 | ||
| 103 | 102 | dat, err := os.Open(filepath.Join(bucket.Path, fpath)) |
+0
-1
pkg/pobj/storage/memory.go
#
+0
-1
pkg/pobj/storage/minio.go
#
| ... | ... | @@ -200,7 +200,6 @@ func (s *StorageMinio) GetObject(bucket Bucket, fpath string) (utils.ReadAndRead | |
| 200 | 200 | objInfo.LastModified = info.LastModified | |
| 201 | 201 | objInfo.ETag = info.ETag | |
| 202 | 202 | objInfo.Metadata = info.Metadata | |
| 203 | - | objInfo.UserMetadata = info.UserMetadata | |
| 204 | 203 | objInfo.Size = info.Size | |
| 205 | 204 | ||
| 206 | 205 | if mtime, ok := info.UserMetadata["Mtime"]; ok { |