git-pr

created pr with 74.1 on 2025-08-21T18:53:46Z · by 964fa508

cmds

checkout latest patchset:

ssh pr.pico.sh print 74 | git am -3

checkout any patchset in a patch request:

ssh pr.pico.sh print 74.[rev] | git am -3

add changes to patch request:

git format-patch main --stdout | ssh pr.pico.sh pr add 74

Patchset `74.1` on 2025-08-21T18:53:46Z · commit 5c73aa5

→ gofumpt and modernize

jolheiser 2025-08-21T18:50:05Z

gofumpt and modernize

jolheiser 2025-08-21T18:50:05Z

This is the result of running:
- gofumpt -> https://github.com/mvdan/gofumpt
- modernize -> https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize

Signed-off-by: jolheiser <git@jolheiser.com>

Semantic diff summary

0 added, 3 modified, 0 signature changed, 0 removed across 3 analyzed files

range_diff.go

chunk lines 11-20 modified

util.go

chunk lines 15-27 modified

web.go

function_declaration createPrDetail modified

+4 -2 range_diff.go #

......@@ -11,8 +11,10 @@ import (
	"github.com/sergi/go-diff/diffmatchpatch"
)

var COST_MAX = 65536
var RANGE_DIFF_CREATION_FACTOR_DEFAULT = 60
var (
	COST_MAX                           = 65536
	RANGE_DIFF_CREATION_FACTOR_DEFAULT = 60
)

type PatchRange struct {
	*Patch

+7 -5 util.go #

......@@ -15,11 +15,13 @@ import (
	"github.com/charmbracelet/ssh"
)

var baseCommitRe = regexp.MustCompile(`base-commit: (.+)\s*`)
var letters = []rune("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ")
var startOfPatch = "From "
var patchsetPrefix = "ps-"
var prPrefix = "pr-"
var (
	baseCommitRe   = regexp.MustCompile(`base-commit: (.+)\s*`)
	letters        = []rune("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ")
	startOfPatch   = "From "
	patchsetPrefix = "ps-"
	prPrefix       = "pr-"
)

// https://stackoverflow.com/a/22892986
func randSeq(n int) string {

+1 -7 web.go #

......@@ -718,13 +718,7 @@ func createPrDetail(page string) http.HandlerFunc {
				}

				// highlight review
				isReview := false
				for _, pID := range reviewIDs {
					if pID == patch.ID {
						isReview = true
						break
					}
				}
				isReview := slices.Contains(reviewIDs, patch.ID)

				patchFiles := []*PatchFile{}
				for _, file := range diffFiles {

...	...		@@ -718,13 +718,7 @@ func createPrDetail(page string) http.HandlerFunc {
718	718		}
719	719
720	720		// highlight review
721		-	isReview := false
722		-	for _, pID := range reviewIDs {
723		-	if pID == patch.ID {
724		-	isReview = true
725		-	break
726		-	}
727		-	}
	721	+	isReview := slices.Contains(reviewIDs, patch.ID)
728	722
729	723		patchFiles := []*PatchFile{}
730	724		for _, file := range diffFiles {

...	...		@@ -11,8 +11,10 @@ import (
11	11		"github.com/sergi/go-diff/diffmatchpatch"
12	12		)
13	13
14		-	var COST_MAX = 65536
15		-	var RANGE_DIFF_CREATION_FACTOR_DEFAULT = 60
	14	+	var (
	15	+	COST_MAX = 65536
	16	+	RANGE_DIFF_CREATION_FACTOR_DEFAULT = 60
	17	+	)
16	18
17	19		type PatchRange struct {
18	20		*Patch

...	...		@@ -15,11 +15,13 @@ import (
15	15		"github.com/charmbracelet/ssh"
16	16		)
17	17
18		-	var baseCommitRe = regexp.MustCompile(`base-commit: (.+)\s*`)
19		-	var letters = []rune("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ")
20		-	var startOfPatch = "From "
21		-	var patchsetPrefix = "ps-"
22		-	var prPrefix = "pr-"
	18	+	var (
	19	+	baseCommitRe = regexp.MustCompile(`base-commit: (.+)\s*`)
	20	+	letters = []rune("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ")
	21	+	startOfPatch = "From "
	22	+	patchsetPrefix = "ps-"
	23	+	prPrefix = "pr-"
	24	+	)
23	25
24	26		// https://stackoverflow.com/a/22892986
25	27		func randSeq(n int) string {

git-pr

Patchset 74.1 on 2025-08-21T18:53:46Z · commit 5c73aa5

Patchset `74.1` on 2025-08-21T18:53:46Z · commit 5c73aa5