pico

created pr with 92.1 on 2025-12-16T04:16:16Z · by c8ef7d19

cmds

checkout latest patchset:

ssh pr.pico.sh print 92 | git am -3

checkout any patchset in a patch request:

ssh pr.pico.sh print 92.[rev] | git am -3

add changes to patch request:

git format-patch main --stdout | ssh pr.pico.sh pr add 92

Patchset `92.1` on 2025-12-16T04:16:16Z · commit 780f9e1

→ fix(pgs): memory leaks

Eric Bower 2025-12-16T04:01:27Z

fix(pgs): gen dir listing close object

Eric Bower 2025-12-16T04:03:51Z

fix: tunnel leaks

Eric Bower 2025-12-16T04:10:10Z

fix: tunkit memory leaks

Eric Bower 2025-12-16T04:13:11Z

fix(pgs): memory leaks

Eric Bower 2025-12-16T04:01:27Z

All changes replace defer with immediate Close() calls to ensure resources are released promptly rather than accumulating until function return.

Semantic diff summary

0 added, 1 modified, 0 signature changed, 0 removed across 1 analyzed file

pkg/apps/pgs/web_asset_handler.go

function_declaration ServeHTTP modified

+5 -9 pkg/apps/pgs/web_asset_handler.go #

......@@ -51,10 +51,8 @@ func (h *ApiAssetHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
		logger.Info("_redirects not found in lru cache", "key", redirectsCacheKey)
		redirectFp, redirectInfo, err := h.Cfg.Storage.GetObject(h.Bucket, filepath.Join(h.ProjectDir, "_redirects"))
		if err == nil {
			defer func() {
				_ = redirectFp.Close()
			}()
			if redirectInfo != nil && redirectInfo.Size > h.Cfg.MaxSpecialFileSize {
				_ = redirectFp.Close()
				errMsg := fmt.Sprintf("_redirects file is too large (%d > %d)", redirectInfo.Size, h.Cfg.MaxSpecialFileSize)
				logger.Error(errMsg)
				http.Error(w, errMsg, http.StatusInternalServerError)

......@@ -63,6 +61,7 @@ func (h *ApiAssetHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
			buf := new(strings.Builder)
			lr := io.LimitReader(redirectFp, h.Cfg.MaxSpecialFileSize)
			_, err := io.Copy(buf, lr)
			_ = redirectFp.Close()
			if err != nil {
				logger.Error("io copy", "err", err.Error())
				http.Error(w, "cannot read _redirects file", http.StatusInternalServerError)

......@@ -109,9 +108,7 @@ func (h *ApiAssetHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
				if err != nil {
					continue
				}
				defer func() {
					_ = obj.Close()
				}()
				_ = obj.Close()
			}
			logger.Info(
				"redirecting request",

......@@ -219,10 +216,8 @@ func (h *ApiAssetHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
		logger.Info("_headers not found in lru cache", "key", headersCacheKey)
		headersFp, headersInfo, err := h.Cfg.Storage.GetObject(h.Bucket, filepath.Join(h.ProjectDir, "_headers"))
		if err == nil {
			defer func() {
				_ = headersFp.Close()
			}()
			if headersInfo != nil && headersInfo.Size > h.Cfg.MaxSpecialFileSize {
				_ = headersFp.Close()
				errMsg := fmt.Sprintf("_headers file is too large (%d > %d)", headersInfo.Size, h.Cfg.MaxSpecialFileSize)
				logger.Error(errMsg)
				http.Error(w, errMsg, http.StatusInternalServerError)

......@@ -231,6 +226,7 @@ func (h *ApiAssetHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
			buf := new(strings.Builder)
			lr := io.LimitReader(headersFp, h.Cfg.MaxSpecialFileSize)
			_, err := io.Copy(buf, lr)
			_ = headersFp.Close()
			if err != nil {
				logger.Error("io copy", "err", err.Error())
				http.Error(w, "cannot read _headers file", http.StatusInternalServerError)

...	...		@@ -51,10 +51,8 @@ func (h ApiAssetHandler) ServeHTTP(w http.ResponseWriter, r http.Request) {
51	51		logger.Info("_redirects not found in lru cache", "key", redirectsCacheKey)
52	52		redirectFp, redirectInfo, err := h.Cfg.Storage.GetObject(h.Bucket, filepath.Join(h.ProjectDir, "_redirects"))
53	53		if err == nil {
54		-	defer func() {
55		-	_ = redirectFp.Close()
56		-	}()
57	54		if redirectInfo != nil && redirectInfo.Size > h.Cfg.MaxSpecialFileSize {
	55	+	_ = redirectFp.Close()
58	56		errMsg := fmt.Sprintf("_redirects file is too large (%d > %d)", redirectInfo.Size, h.Cfg.MaxSpecialFileSize)
59	57		logger.Error(errMsg)
60	58		http.Error(w, errMsg, http.StatusInternalServerError)

...	...		@@ -63,6 +61,7 @@ func (h ApiAssetHandler) ServeHTTP(w http.ResponseWriter, r http.Request) {
63	61		buf := new(strings.Builder)
64	62		lr := io.LimitReader(redirectFp, h.Cfg.MaxSpecialFileSize)
65	63		_, err := io.Copy(buf, lr)
	64	+	_ = redirectFp.Close()
66	65		if err != nil {
67	66		logger.Error("io copy", "err", err.Error())
68	67		http.Error(w, "cannot read _redirects file", http.StatusInternalServerError)

...	...		@@ -109,9 +108,7 @@ func (h ApiAssetHandler) ServeHTTP(w http.ResponseWriter, r http.Request) {
109	108		if err != nil {
110	109		continue
111	110		}
112		-	defer func() {
113		-	_ = obj.Close()
114		-	}()
	111	+	_ = obj.Close()
115	112		}
116	113		logger.Info(
117	114		"redirecting request",

...	...		@@ -219,10 +216,8 @@ func (h ApiAssetHandler) ServeHTTP(w http.ResponseWriter, r http.Request) {
219	216		logger.Info("_headers not found in lru cache", "key", headersCacheKey)
220	217		headersFp, headersInfo, err := h.Cfg.Storage.GetObject(h.Bucket, filepath.Join(h.ProjectDir, "_headers"))
221	218		if err == nil {
222		-	defer func() {
223		-	_ = headersFp.Close()
224		-	}()
225	219		if headersInfo != nil && headersInfo.Size > h.Cfg.MaxSpecialFileSize {
	220	+	_ = headersFp.Close()
226	221		errMsg := fmt.Sprintf("_headers file is too large (%d > %d)", headersInfo.Size, h.Cfg.MaxSpecialFileSize)
227	222		logger.Error(errMsg)
228	223		http.Error(w, errMsg, http.StatusInternalServerError)

...	...		@@ -231,6 +226,7 @@ func (h ApiAssetHandler) ServeHTTP(w http.ResponseWriter, r http.Request) {
231	226		buf := new(strings.Builder)
232	227		lr := io.LimitReader(headersFp, h.Cfg.MaxSpecialFileSize)
233	228		_, err := io.Copy(buf, lr)
	229	+	_ = headersFp.Close()
234	230		if err != nil {
235	231		logger.Error("io copy", "err", err.Error())
236	232		http.Error(w, "cannot read _headers file", http.StatusInternalServerError)

pico

Patchset 92.1 on 2025-12-16T04:16:16Z · commit 780f9e1

Patchset `92.1` on 2025-12-16T04:16:16Z · commit 780f9e1