git-pr

created pr with 16.1 on 2024-08-18T15:28:14Z · by c8ef7d19

added 16.2 on 2024-08-18T15:31:36Z · by c8ef7d19


                      1:  3bd44da ! 1:  9002592 chore(pgs): add validation to project names

added 16.3 on 2024-08-18T16:05:53Z · by c8ef7d19


                      1:  9002592 = 1:  9002592 chore(pgs): add validation to project names


                      -:  ------- > 2:  cd17cf4 chore: update pobj


                      -:  ------- > 3:  a00def2 chore: complete impl

changed pr name to feat: private obj store service on 2024-08-18T16:06:30Z · by c8ef7d19

added 16.4 on 2024-08-18T16:39:07Z · by c8ef7d19


                      1:  9002592 = 1:  9002592 chore(pgs): add validation to project names


                      2:  cd17cf4 = 2:  cd17cf4 chore: update pobj


                      3:  a00def2 = 3:  a00def2 chore: complete impl


                      -:  ------- > 4:  0ed7dc9 chore: update pobj


                      -:  ------- > 5:  8ff1131 working!

added 16.5 on 2024-08-19T02:01:34Z · by c8ef7d19


                      1:  9002592 = 1:  9002592 chore(pgs): add validation to project names


                      2:  cd17cf4 = 2:  cd17cf4 chore: update pobj


                      3:  a00def2 = 3:  a00def2 chore: complete impl


                      4:  0ed7dc9 = 4:  0ed7dc9 chore: update pobj


                      5:  8ff1131 = 5:  8ff1131 working!


                      -:  ------- > 6:  0c8ad0d chore(obj): prep service def

cmds

checkout latest patchset:

ssh pr.pico.sh print 16 | git am -3

checkout any patchset in a patch request:

ssh pr.pico.sh print 16.[rev] | git am -3

add changes to patch request:

git format-patch main --stdout | ssh pr.pico.sh pr add 16

Patchset `16.1` on 2024-08-18T15:28:14Z · commit 3bd44da

→ chore(pgs): add validation to project names

Eric Bower 2024-08-18T15:27:37Z

chore(pgs): add validation to project names

Eric Bower 2024-08-18T15:27:37Z

Semantic diff summary

1 added, 2 modified, 0 signature changed, 0 removed across 3 analyzed files

filehandlers/assets/handler.go

function_declaration Write modified

pgs/cli.go

function_declaration unlink modified

shared/bucket.go

function_declaration ValidateProjectName added

+5 -0 filehandlers/assets/handler.go #

......@@ -268,6 +268,11 @@ func (h *UploadAssetHandler) Write(s ssh.Session, entry *utils.FileEntry) (strin

	project := getProject(s)
	projectName := shared.GetProjectName(entry)
	err = shared.ValidateProjectName(projectName)
	if err != nil {
		return "", err
	}

	logger = logger.With("project", projectName)

	// find, create, or update project if we haven't already done it

+6 -1 pgs/cli.go #

......@@ -374,8 +374,13 @@ func (c *Cmd) unlink(projectName string) error {
func (c *Cmd) link(projectName, linkTo string) error {
	c.Log.Info("user running `link` command", "user", c.User.Name, "project", projectName, "link", linkTo)

	err := shared.ValidateProjectName(projectName)
	if err != nil {
		return err
	}

	projectDir := linkTo
	_, err := c.Dbpool.FindProjectByName(c.User.ID, linkTo)
	_, err = c.Dbpool.FindProjectByName(c.User.ID, linkTo)
	if err != nil {
		e := fmt.Errorf("(%s) project doesn't exist", linkTo)
		return e

+7 -0 shared/bucket.go #

......@@ -17,6 +17,13 @@ func GetAssetBucketName(userID string) string {
	return fmt.Sprintf("static-%s", userID)
}

func ValidateProjectName(projectName string) error {
	if projectName == "pico-private" {
		return fmt.Errorf("%s is an invalid project name", projectName)
	}
	return nil
}

func GetProjectName(entry *utils.FileEntry) string {
	if entry.Mode.IsDir() && strings.Count(entry.Filepath, string(os.PathSeparator)) == 0 {
		return entry.Filepath

...	...		@@ -268,6 +268,11 @@ func (h UploadAssetHandler) Write(s ssh.Session, entry utils.FileEntry) (strin
268	268
269	269		project := getProject(s)
270	270		projectName := shared.GetProjectName(entry)
	271	+	err = shared.ValidateProjectName(projectName)
	272	+	if err != nil {
	273	+	return "", err
	274	+	}
	275	+
271	276		logger = logger.With("project", projectName)
272	277
273	278		// find, create, or update project if we haven't already done it

...	...		@@ -374,8 +374,13 @@ func (c *Cmd) unlink(projectName string) error {
374	374		func (c *Cmd) link(projectName, linkTo string) error {
375	375		c.Log.Info("user running `link` command", "user", c.User.Name, "project", projectName, "link", linkTo)
376	376
	377	+	err := shared.ValidateProjectName(projectName)
	378	+	if err != nil {
	379	+	return err
	380	+	}
	381	+
377	382		projectDir := linkTo
378		-	_, err := c.Dbpool.FindProjectByName(c.User.ID, linkTo)
	383	+	_, err = c.Dbpool.FindProjectByName(c.User.ID, linkTo)
379	384		if err != nil {
380	385		e := fmt.Errorf("(%s) project doesn't exist", linkTo)
381	386		return e

...	...		@@ -17,6 +17,13 @@ func GetAssetBucketName(userID string) string {
17	17		return fmt.Sprintf("static-%s", userID)
18	18		}
19	19
	20	+	func ValidateProjectName(projectName string) error {
	21	+	if projectName == "pico-private" {
	22	+	return fmt.Errorf("%s is an invalid project name", projectName)
	23	+	}
	24	+	return nil
	25	+	}
	26	+
20	27		func GetProjectName(entry *utils.FileEntry) string {
21	28		if entry.Mode.IsDir() && strings.Count(entry.Filepath, string(os.PathSeparator)) == 0 {
22	29		return entry.Filepath

git-pr

Patchset 16.1 on 2024-08-18T15:28:14Z · commit 3bd44da

Patchset `16.1` on 2024-08-18T15:28:14Z · commit 3bd44da