cheogram-www

created pr with cheogram-www/react-compiler-fixes.1 on 2026-11-10T18:57:22Z · by 3c31bc8c

commented on 2026-11-10T18:57:22Z · by 3c31bc8c

Changes are available at https://tangled.org/mrry.band/cheogram-www on branch react-compiler-fixes.

cmds

checkout latest patchset:

ssh pr.pico.sh pull cheogram-www:react-compiler-fixes | git am -3

checkout specific patchset revision:

ssh pr.pico.sh pull cheogram-www:react-compiler-fixes [rev] | git am -3

add changes to patch request:

git format-patch main --stdout | ssh pr.pico.sh cheogram-www:react-compiler-fixes

add comment to patch request:

ssh pr.pico.sh comment cheogram-www:react-compiler-fixes "lgtm!"

Patchset `cheogram-www/react-compiler-fixes.1` on 2026-11-10T18:57:22Z · commit 6e7acd1

Test each file for compilability

Eric Roberts 2026-11-10T17:11:18Z

Fix Account.tsx for react-compiler

Eric Roberts 2026-11-10T17:23:58Z

→ Fix Accounts.tsx for react-compiler

Eric Roberts 2026-11-10T17:26:31Z

Fix Chat.tsx for react-compiler

Eric Roberts 2026-11-10T17:29:12Z

Fix Chats.tsx for react-compiler

Eric Roberts 2026-11-10T17:32:03Z

Fix Login.tsx for react-compiler

Eric Roberts 2026-11-10T17:33:10Z

Fix MessageDebugger.tsx for react-compiler

Eric Roberts 2026-11-10T17:33:57Z

Fix MessageMenuInChat.tsx for react-compiler

Eric Roberts 2026-11-10T17:34:29Z

Fix Quill.tsx for react-compiler

Eric Roberts 2026-11-10T17:35:10Z

Fix Register.tsx for react-compiler

Eric Roberts 2026-11-10T17:36:03Z

Fix Accounts.tsx for react-compiler

Eric Roberts 2026-11-10T17:26:31Z

The compiler mistakes reauth.usePassword() for a React hook:

    Hooks must be called at the top level of a function component
    or custom Hook

Added a reauthenticate helper to fix it.

Semantic diff summary

1 added, 3 modified, 0 signature changed, 0 removed across 3 analyzed files

scripts/compiler.test.mjs

chunk lines 4-9 modified

src/components/Accounts.tsx

chunk lines 33-39 modified
chunk lines 321-328 modified

src/util.ts

function_declaration reauthenticate added

+0 -1 scripts/compiler.test.mjs #

......@@ -4,7 +4,6 @@ import { test } from "node:test";
import { createServer } from "vite";

const compilerSkips = new Set([
	"components/Accounts.tsx",
	"components/Chat.tsx",
	"components/Chats.tsx",
	"components/Login.tsx",

+3 -2 src/components/Accounts.tsx #

......@@ -33,7 +33,7 @@ import {
} from "@fortawesome/free-solid-svg-icons";

import { SettingsContext } from "./Settings";
import { useChats, readyServiceWorker } from "../util";
import { useChats, readyServiceWorker, reauthenticate } from "../util";

export const Accounts = () => {
	const { accounts, setAccounts, persistence, setSettings } =

......@@ -321,7 +321,8 @@ export const Accounts = () => {
									id="reauth-form"
									onSubmit={(e) => {
										e.preventDefault();
										reauth?.usePassword(e.currentTarget.password.value);
										if (reauth)
											reauthenticate(reauth, e.currentTarget.password.value);
										setStatus("connecting");
										setReauth(undefined);
									}}

+4 -0 src/util.ts #

......@@ -11,6 +11,10 @@ export const loadEmojiData = async () => ({
	...(await import("@emoji-mart/data")),
});

export function reauthenticate(client: borogove.Client, password: string) {
	client.usePassword(password);
}

export const ios = navigator.userAgent.match(/(iPad|iPhone|iPod)/g);
export const webkit =
	navigator.userAgent.match(/AppleWebKit/) &&

...	...		@@ -4,7 +4,6 @@ import { test } from "node:test";
4	4		import { createServer } from "vite";
5	5
6	6		const compilerSkips = new Set([
7		-	"components/Accounts.tsx",
8	7		"components/Chat.tsx",
9	8		"components/Chats.tsx",
10	9		"components/Login.tsx",

...	...		@@ -33,7 +33,7 @@ import {
33	33		} from "@fortawesome/free-solid-svg-icons";
34	34
35	35		import { SettingsContext } from "./Settings";
36		-	import { useChats, readyServiceWorker } from "../util";
	36	+	import { useChats, readyServiceWorker, reauthenticate } from "../util";
37	37
38	38		export const Accounts = () => {
39	39		const { accounts, setAccounts, persistence, setSettings } =

...	...		@@ -321,7 +321,8 @@ export const Accounts = () => {
321	321		id="reauth-form"
322	322		onSubmit={(e) => {
323	323		e.preventDefault();
324		-	reauth?.usePassword(e.currentTarget.password.value);
	324	+	if (reauth)
	325	+	reauthenticate(reauth, e.currentTarget.password.value);
325	326		setStatus("connecting");
326	327		setReauth(undefined);
327	328		}}

...	...		@@ -11,6 +11,10 @@ export const loadEmojiData = async () => ({
11	11		...(await import("@emoji-mart/data")),
12	12		});
13	13
	14	+	export function reauthenticate(client: borogove.Client, password: string) {
	15	+	client.usePassword(password);
	16	+	}
	17	+
14	18		export const ios = navigator.userAgent.match(/(iPad\|iPhone\|iPod)/g);
15	19		export const webkit =
16	20		navigator.userAgent.match(/AppleWebKit/) &&

cheogram-www

Patchset cheogram-www/react-compiler-fixes.1 on 2026-11-10T18:57:22Z · commit 6e7acd1

Patchset `cheogram-www/react-compiler-fixes.1` on 2026-11-10T18:57:22Z · commit 6e7acd1