cheogram-www

created pr with cheogram-www/react-compiler-fixes.1 on 2026-11-10T18:57:22Z · by 3c31bc8c

commented on 2026-11-10T18:57:22Z · by 3c31bc8c

Changes are available at https://tangled.org/mrry.band/cheogram-www on branch react-compiler-fixes.

cmds

checkout latest patchset:

ssh pr.pico.sh pull cheogram-www:react-compiler-fixes | git am -3

checkout specific patchset revision:

ssh pr.pico.sh pull cheogram-www:react-compiler-fixes [rev] | git am -3

add changes to patch request:

git format-patch main --stdout | ssh pr.pico.sh cheogram-www:react-compiler-fixes

add comment to patch request:

ssh pr.pico.sh comment cheogram-www:react-compiler-fixes "lgtm!"

Patchset `cheogram-www/react-compiler-fixes.1` on 2026-11-10T18:57:22Z · commit 5d03f4f

Test each file for compilability

Eric Roberts 2026-11-10T17:11:18Z

Fix Account.tsx for react-compiler

Eric Roberts 2026-11-10T17:23:58Z

Fix Accounts.tsx for react-compiler

Eric Roberts 2026-11-10T17:26:31Z

Fix Chat.tsx for react-compiler

Eric Roberts 2026-11-10T17:29:12Z

Fix Chats.tsx for react-compiler

Eric Roberts 2026-11-10T17:32:03Z

→ Fix Login.tsx for react-compiler

Eric Roberts 2026-11-10T17:33:10Z

Fix MessageDebugger.tsx for react-compiler

Eric Roberts 2026-11-10T17:33:57Z

Fix MessageMenuInChat.tsx for react-compiler

Eric Roberts 2026-11-10T17:34:29Z

Fix Quill.tsx for react-compiler

Eric Roberts 2026-11-10T17:35:10Z

Fix Register.tsx for react-compiler

Eric Roberts 2026-11-10T17:36:03Z

Fix Login.tsx for react-compiler

Eric Roberts 2026-11-10T17:33:10Z

The compiler mistakes client.usePassword() for a React hook:

    Hooks must be called at the top level of a function component
    or custom Hook

Call the reauthenticate helper instead

Semantic diff summary

0 added, 3 modified, 0 signature changed, 0 removed across 2 analyzed files

scripts/compiler.test.mjs

chunk lines 4-9 modified

src/components/Login.tsx

chunk lines 1-5 modified
chunk lines 151-157 modified

+0 -1 scripts/compiler.test.mjs #

......@@ -4,7 +4,6 @@ import { test } from "node:test";
import { createServer } from "vite";

const compilerSkips = new Set([
	"components/Login.tsx",
	"components/MessageDebugger.tsx",
	"components/MessageMenuInChat.tsx",
	"components/Quill.tsx",

+2 -2 src/components/Login.tsx #

......@@ -1,5 +1,5 @@
import * as borogove from "borogove";
import { readyServiceWorker } from "../util";
import { readyServiceWorker, reauthenticate } from "../util";
import { Link, Navigate, useOutletContext } from "react-router";
import { Context } from "../App";
import { useEffect, useRef, useState } from "react";

......@@ -151,7 +151,7 @@ export const Login = () => {
						});
					} else {
						setAuthAttempts(authAttempts + 1);
						account.client.usePassword(e.currentTarget.password.value);
						reauthenticate(account.client, e.currentTarget.password.value);
						setStatus("connecting");
					}
				}}

...	...		@@ -4,7 +4,6 @@ import { test } from "node:test";
4	4		import { createServer } from "vite";
5	5
6	6		const compilerSkips = new Set([
7		-	"components/Login.tsx",
8	7		"components/MessageDebugger.tsx",
9	8		"components/MessageMenuInChat.tsx",
10	9		"components/Quill.tsx",

...	...		@@ -1,5 +1,5 @@
1	1		import * as borogove from "borogove";
2		-	import { readyServiceWorker } from "../util";
	2	+	import { readyServiceWorker, reauthenticate } from "../util";
3	3		import { Link, Navigate, useOutletContext } from "react-router";
4	4		import { Context } from "../App";
5	5		import { useEffect, useRef, useState } from "react";

...	...		@@ -151,7 +151,7 @@ export const Login = () => {
151	151		});
152	152		} else {
153	153		setAuthAttempts(authAttempts + 1);
154		-	account.client.usePassword(e.currentTarget.password.value);
	154	+	reauthenticate(account.client, e.currentTarget.password.value);
155	155		setStatus("connecting");
156	156		}
157	157		}}

cheogram-www

Patchset cheogram-www/react-compiler-fixes.1 on 2026-11-10T18:57:22Z · commit 5d03f4f

Patchset `cheogram-www/react-compiler-fixes.1` on 2026-11-10T18:57:22Z · commit 5d03f4f