cheogram-www

created pr with cheogram-www/react-compiler-fixes.1 on 2026-11-10T18:57:22Z · by 3c31bc8c

commented on 2026-11-10T18:57:22Z · by 3c31bc8c

Changes are available at https://tangled.org/mrry.band/cheogram-www on branch react-compiler-fixes.

cmds

checkout latest patchset:

ssh pr.pico.sh pull cheogram-www:react-compiler-fixes | git am -3

checkout specific patchset revision:

ssh pr.pico.sh pull cheogram-www:react-compiler-fixes [rev] | git am -3

add changes to patch request:

git format-patch main --stdout | ssh pr.pico.sh cheogram-www:react-compiler-fixes

add comment to patch request:

ssh pr.pico.sh comment cheogram-www:react-compiler-fixes "lgtm!"

Patchset `cheogram-www/react-compiler-fixes.1` on 2026-11-10T18:57:22Z · commit d63b939

Test each file for compilability

Eric Roberts 2026-11-10T17:11:18Z

Fix Account.tsx for react-compiler

Eric Roberts 2026-11-10T17:23:58Z

Fix Accounts.tsx for react-compiler

Eric Roberts 2026-11-10T17:26:31Z

→ Fix Chat.tsx for react-compiler

Eric Roberts 2026-11-10T17:29:12Z

Fix Chats.tsx for react-compiler

Eric Roberts 2026-11-10T17:32:03Z

Fix Login.tsx for react-compiler

Eric Roberts 2026-11-10T17:33:10Z

Fix MessageDebugger.tsx for react-compiler

Eric Roberts 2026-11-10T17:33:57Z

Fix MessageMenuInChat.tsx for react-compiler

Eric Roberts 2026-11-10T17:34:29Z

Fix Quill.tsx for react-compiler

Eric Roberts 2026-11-10T17:35:10Z

Fix Register.tsx for react-compiler

Eric Roberts 2026-11-10T17:36:03Z

Fix Chat.tsx for react-compiler

Eric Roberts 2026-11-10T17:29:12Z

The compiler doesn't support try/finally:

    (BuildHIR::lowerStatement) Handle TryStatement with a finalizer
    ('finally') clause

Use .catch() and .finally() on the upload promise instead

Semantic diff summary

0 added, 2 modified, 0 signature changed, 0 removed across 2 analyzed files

scripts/compiler.test.mjs

chunk lines 4-9 modified

src/components/Chat.tsx

chunk lines 852-876 modified

+0 -1 scripts/compiler.test.mjs #

......@@ -4,7 +4,6 @@ import { test } from "node:test";
import { createServer } from "vite";

const compilerSkips = new Set([
	"components/Chat.tsx",
	"components/Chats.tsx",
	"components/Login.tsx",
	"components/MessageDebugger.tsx",

+19 -19 src/components/Chat.tsx #

......@@ -852,25 +852,25 @@ export const ChatInner = () => {
			activeChat instanceof borogove.Channel && !activeChat.isPrivate();
		setAttachmentError(null);
		setAttachmentProgress(true);
		try {
			await Promise.all(
				files.map((file) =>
					client.prepareAttachment(file, !isPublicChat).then((attachment) => {
						if (attachment === null) throw new Error("Attachment failed");

						setAttachments((existing) => [
							...existing,
							{ attachment, uri: URL.createObjectURL(file) },
						]);
					}),
				),
			);
		} catch (error) {
			console.error("Attachment upload failed", error);
			setAttachmentError(attachmentErrorMessage(error));
		} finally {
			setAttachmentProgress(false);
		}
		await Promise.all(
			files.map((file) =>
				client.prepareAttachment(file, !isPublicChat).then((attachment) => {
					if (attachment === null) throw new Error("Attachment failed");

					setAttachments((existing) => [
						...existing,
						{ attachment, uri: URL.createObjectURL(file) },
					]);
				}),
			),
		)
			.catch((error) => {
				console.error("Attachment upload failed", error);
				setAttachmentError(attachmentErrorMessage(error));
			})
			.finally(() => {
				setAttachmentProgress(false);
			});
	};

	const handleAttach = () => {

...	...		@@ -4,7 +4,6 @@ import { test } from "node:test";
4	4		import { createServer } from "vite";
5	5
6	6		const compilerSkips = new Set([
7		-	"components/Chat.tsx",
8	7		"components/Chats.tsx",
9	8		"components/Login.tsx",
10	9		"components/MessageDebugger.tsx",

...	...		@@ -852,25 +852,25 @@ export const ChatInner = () => {
852	852		activeChat instanceof borogove.Channel && !activeChat.isPrivate();
853	853		setAttachmentError(null);
854	854		setAttachmentProgress(true);
855		-	try {
856		-	await Promise.all(
857		-	files.map((file) =>
858		-	client.prepareAttachment(file, !isPublicChat).then((attachment) => {
859		-	if (attachment === null) throw new Error("Attachment failed");
860		-
861		-	setAttachments((existing) => [
862		-	...existing,
863		-	{ attachment, uri: URL.createObjectURL(file) },
864		-	]);
865		-	}),
866		-	),
867		-	);
868		-	} catch (error) {
869		-	console.error("Attachment upload failed", error);
870		-	setAttachmentError(attachmentErrorMessage(error));
871		-	} finally {
872		-	setAttachmentProgress(false);
873		-	}
	855	+	await Promise.all(
	856	+	files.map((file) =>
	857	+	client.prepareAttachment(file, !isPublicChat).then((attachment) => {
	858	+	if (attachment === null) throw new Error("Attachment failed");
	859	+
	860	+	setAttachments((existing) => [
	861	+	...existing,
	862	+	{ attachment, uri: URL.createObjectURL(file) },
	863	+	]);
	864	+	}),
	865	+	),
	866	+	)
	867	+	.catch((error) => {
	868	+	console.error("Attachment upload failed", error);
	869	+	setAttachmentError(attachmentErrorMessage(error));
	870	+	})
	871	+	.finally(() => {
	872	+	setAttachmentProgress(false);
	873	+	});
874	874		};
875	875
876	876		const handleAttach = () => {

cheogram-www

Patchset cheogram-www/react-compiler-fixes.1 on 2026-11-10T18:57:22Z · commit d63b939

Patchset `cheogram-www/react-compiler-fixes.1` on 2026-11-10T18:57:22Z · commit d63b939