cheogram-www

created pr with cheogram-www/react-compiler-fixes.1 on 2026-11-10T18:57:22Z · by 3c31bc8c

commented on 2026-11-10T18:57:22Z · by 3c31bc8c

Changes are available at https://tangled.org/mrry.band/cheogram-www on branch react-compiler-fixes.

cmds

checkout latest patchset:

ssh pr.pico.sh pull cheogram-www:react-compiler-fixes | git am -3

checkout specific patchset revision:

ssh pr.pico.sh pull cheogram-www:react-compiler-fixes [rev] | git am -3

add changes to patch request:

git format-patch main --stdout | ssh pr.pico.sh cheogram-www:react-compiler-fixes

add comment to patch request:

ssh pr.pico.sh comment cheogram-www:react-compiler-fixes "lgtm!"

Patchset `cheogram-www/react-compiler-fixes.1` on 2026-11-10T18:57:22Z · commit 316b569

Test each file for compilability

Eric Roberts 2026-11-10T17:11:18Z

Fix Account.tsx for react-compiler

Eric Roberts 2026-11-10T17:23:58Z

Fix Accounts.tsx for react-compiler

Eric Roberts 2026-11-10T17:26:31Z

Fix Chat.tsx for react-compiler

Eric Roberts 2026-11-10T17:29:12Z

Fix Chats.tsx for react-compiler

Eric Roberts 2026-11-10T17:32:03Z

Fix Login.tsx for react-compiler

Eric Roberts 2026-11-10T17:33:10Z

→ Fix MessageDebugger.tsx for react-compiler

Eric Roberts 2026-11-10T17:33:57Z

Fix MessageMenuInChat.tsx for react-compiler

Eric Roberts 2026-11-10T17:34:29Z

Fix Quill.tsx for react-compiler

Eric Roberts 2026-11-10T17:35:10Z

Fix Register.tsx for react-compiler

Eric Roberts 2026-11-10T17:36:03Z

Fix MessageDebugger.tsx for react-compiler

Eric Roberts 2026-11-10T17:33:57Z

The compiler can't handle throwing inside try/catch:

    (BuildHIR::lowerStatement) Support ThrowStatement inside of try/catch

They don't support this because they think you shouldn't do it:

> /*
> * NOTE: we could support this, but a `throw` inside try/catch is using exceptions
> * for control-flow and is generally considered an anti-pattern. we can likely
> * just not support this pattern, unless it really becomes necessary for some reason.
> */

https://github.com/react/react/blob/main/compiler/packages/babel-plugin-react-compiler/src/HIR/BuildHIR.ts#L281-L285

Weird choice IMO but whatever.

Moved to a function outside the component.

Semantic diff summary

1 added, 2 modified, 0 signature changed, 0 removed across 2 analyzed files

scripts/compiler.test.mjs

chunk lines 4-9 modified

src/components/MessageDebugger.tsx

function_declaration lookupAndExposeMessage added
chunk lines 72-78 modified

+0 -1 scripts/compiler.test.mjs #

......@@ -4,7 +4,6 @@ import { test } from "node:test";
import { createServer } from "vite";

const compilerSkips = new Set([
	"components/MessageDebugger.tsx",
	"components/MessageMenuInChat.tsx",
	"components/Quill.tsx",
	"components/Register.tsx",

+21 -13 src/components/MessageDebugger.tsx #

......@@ -25,6 +25,26 @@ function exposeMessage(message: ChatMessage) {
	console.log(`${name} (window.${name})`, message);
}

async function lookupAndExposeMessage(
	persistence: Persistence,
	m: ChatMessage,
	serverId: string,
) {
	try {
		const message = await persistence.getMessage(
			m.account(),
			m.chatId(),
			serverId,
			null,
		);
		if (!message)
			throw new Error(`No stored message for server ID ${serverId}`);
		exposeMessage(message);
	} catch (error) {
		console.error("Message debugger lookup failed", serverId, error);
	}
}

export const MessageDebugger = ({ m }: { m: ChatMessage }) =>
	debugEnabled ? <MessageDebuggerButton m={m} /> : null;

......@@ -52,19 +72,7 @@ const MessageDebuggerButton = ({ m }: { m: ChatMessage }) => {
					}
					clearTimeout(feedbackTimer.current);
					feedbackTimer.current = setTimeout(() => setFeedback(""), 1000);
					try {
						const message = await persistence.getMessage(
							m.account(),
							m.chatId(),
							serverId,
							null,
						);
						if (!message)
							throw new Error(`No stored message for server ID ${serverId}`);
						exposeMessage(message);
					} catch (error) {
						console.error("Message debugger lookup failed", serverId, error);
					}
					await lookupAndExposeMessage(persistence, m, serverId);
				}}
			>
				{serverId}

...	...		@@ -4,7 +4,6 @@ import { test } from "node:test";
4	4		import { createServer } from "vite";
5	5
6	6		const compilerSkips = new Set([
7		-	"components/MessageDebugger.tsx",
8	7		"components/MessageMenuInChat.tsx",
9	8		"components/Quill.tsx",
10	9		"components/Register.tsx",

...	...		@@ -25,6 +25,26 @@ function exposeMessage(message: ChatMessage) {
25	25		console.log(`${name} (window.${name})`, message);
26	26		}
27	27
	28	+	async function lookupAndExposeMessage(
	29	+	persistence: Persistence,
	30	+	m: ChatMessage,
	31	+	serverId: string,
	32	+	) {
	33	+	try {
	34	+	const message = await persistence.getMessage(
	35	+	m.account(),
	36	+	m.chatId(),
	37	+	serverId,
	38	+	null,
	39	+	);
	40	+	if (!message)
	41	+	throw new Error(`No stored message for server ID ${serverId}`);
	42	+	exposeMessage(message);
	43	+	} catch (error) {
	44	+	console.error("Message debugger lookup failed", serverId, error);
	45	+	}
	46	+	}
	47	+
28	48		export const MessageDebugger = ({ m }: { m: ChatMessage }) =>
29	49		debugEnabled ? <MessageDebuggerButton m={m} /> : null;
30	50

...	...		@@ -52,19 +72,7 @@ const MessageDebuggerButton = ({ m }: { m: ChatMessage }) => {
52	72		}
53	73		clearTimeout(feedbackTimer.current);
54	74		feedbackTimer.current = setTimeout(() => setFeedback(""), 1000);
55		-	try {
56		-	const message = await persistence.getMessage(
57		-	m.account(),
58		-	m.chatId(),
59		-	serverId,
60		-	null,
61		-	);
62		-	if (!message)
63		-	throw new Error(`No stored message for server ID ${serverId}`);
64		-	exposeMessage(message);
65		-	} catch (error) {
66		-	console.error("Message debugger lookup failed", serverId, error);
67		-	}
	75	+	await lookupAndExposeMessage(persistence, m, serverId);
68	76		}}
69	77		>
70	78		{serverId}

cheogram-www

Patchset cheogram-www/react-compiler-fixes.1 on 2026-11-10T18:57:22Z · commit 316b569

Patchset `cheogram-www/react-compiler-fixes.1` on 2026-11-10T18:57:22Z · commit 316b569